From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2 0/7] add helpers and vars in mptcp_lib.sh, part 4
Date: Fri, 8 Mar 2024 22:47:41 +0100 [thread overview]
Message-ID: <9ed8ca5d-5e9d-4fc7-88f9-3aca60b9febe@kernel.org> (raw)
In-Reply-To: <ZesSLljdEO9xou4X@t480>
Hi Geliang,
On 08/03/2024 14:27, Geliang Tang wrote:
> Hi Matt,
>
> On Fri, Mar 08, 2024 at 01:11:43PM +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 08/03/2024 11:35, Matthieu Baerts wrote:
>>> Hi Geliang,
>>>
>>> On 08/03/2024 06:57, Geliang Tang wrote:
>>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>>
>>>> v2:
>>>> - add new patches #1 & #3
>>>> - #2 drop the tab in
>>>> "\tExpected value for '${var}': '${!exp}', got '${!var}'.", this breaks
>>>> the alignments.
>>>> - drop 'rc' in patch #2 & #4
>>>> - use declare in #5
>>>> - drop
>>>> extra_srv_args+=" $extra_args"
>>>> extra_cl_args+=" $extra_args"
>>>> in #7
>>>
>>> Thank you for the new version!
>>>
>>> Did you check that after your modifications errors are still caught as
>>> before, and presented correctly? (the CI didn't get any error)
>>
>
> Yes, I checked the error logs, they are fine as before.
Thank you for having checked!
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-03-08 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 5:57 [PATCH mptcp-next v2 0/7] add helpers and vars in mptcp_lib.sh, part 4 Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 1/7] selftests: mptcp: call test_fail without argument Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 2/7] selftests: mptcp: extract mptcp_lib_check_expected Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 3/7] selftests: mptcp: print_test out of verify_listener_events Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 4/7] selftests: mptcp: add mptcp_lib_verify_listener_events Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 5/7] selftests: mptcp: declare event macros in mptcp_lib Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 6/7] selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL Geliang Tang
2024-03-08 5:57 ` [PATCH mptcp-next v2 7/7] selftests: mptcp: join: use += operator to append strings Geliang Tang
2024-03-08 7:01 ` selftests: mptcp: join: use += operator to append strings: Tests Results MPTCP CI
2024-03-08 8:00 ` MPTCP CI
2024-03-08 10:35 ` [PATCH mptcp-next v2 0/7] add helpers and vars in mptcp_lib.sh, part 4 Matthieu Baerts
2024-03-08 12:11 ` Matthieu Baerts
2024-03-08 13:27 ` Geliang Tang
2024-03-08 21:47 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ed8ca5d-5e9d-4fc7-88f9-3aca60b9febe@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).