From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 3/3] checkpatch: skip warnings for symbol links
Date: Wed, 15 May 2024 18:43:00 +0200 [thread overview]
Message-ID: <63507d19-aa98-4964-83b8-ba0a5d84aa2e@kernel.org> (raw)
In-Reply-To: <1628d78e12809ff0f4dd0526f6addbbf00dae66b.1715503185.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 12/05/2024 10:41, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> If there is a symbol link in the given patch, checkpatch.pl reports two
> inaccurate warnings:
>
> $ cat 0001-selftests-bpf-Add-mptcp-pm_nl_ctl-link.patch
>
> ... ...
>
> '''
> # diff --git a/tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c \
> # b/tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c
> # new file mode 120000
> # index 000000000000..5a08c255b278
> # --- /dev/null
> # +++ b/tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c
> # @@ -0,0 +1 @@
> # +../net/mptcp/pm_nl_ctl.c
> # \ No newline at end of file
> '''
>
> $ ./scripts/checkpatch.pl 0001-selftests-bpf-Add-mptcp-pm_nl_ctl-link.patch
>
> '''
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> #57: FILE: tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c:1:
> +../net/mptcp/pm_nl_ctl.c
>
> WARNING: adding a line without newline at end of file
> #57: FILE: tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c:1:
> +../net/mptcp/pm_nl_ctl.c
>
> total: 0 errors, 2 warnings, 16 lines checked
> '''
With 'checkpatch.pl --strict', I also had these warnings:
> CHECK: spaces preferred around that '/' (ctx:VxV)
> #63: FILE: tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c:1:
> +../net/mptcp/pm_nl_ctl.c
> ^
>
> CHECK: spaces preferred around that '/' (ctx:VxV)
> #63: FILE: tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c:1:
> +../net/mptcp/pm_nl_ctl.c
> ^
>
> CHECK: spaces preferred around that '/' (ctx:VxV)
> #63: FILE: tools/testing/selftests/bpf/mptcp_pm_nl_ctl.c:1:
> +../net/mptcp/pm_nl_ctl.c
> ^
I guess a similar fix could be done for this check as well :)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-05-15 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 8:41 [PATCH mptcp-next v4 0/3] patches for new MPTCP subflow subtest Geliang Tang
2024-05-12 8:41 ` [PATCH mptcp-next v4 1/3] selftests/bpf: Add mptcp pm_nl_ctl link Geliang Tang
2024-05-12 8:41 ` [PATCH mptcp-next v4 2/3] Squash to "selftests/bpf: Add mptcp subflow subtest" Geliang Tang
2024-05-13 10:38 ` Matthieu Baerts
2024-05-12 8:41 ` [PATCH mptcp-next v4 3/3] checkpatch: skip warnings for symbol links Geliang Tang
2024-05-13 10:44 ` Matthieu Baerts
2024-05-15 16:43 ` Matthieu Baerts [this message]
2024-05-12 9:34 ` [PATCH mptcp-next v4 0/3] patches for new MPTCP subflow subtest MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63507d19-aa98-4964-83b8-ba0a5d84aa2e@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).