MPTCP Archive mirror
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: CI: MPTCP BPF tests are now validated
Date: Mon, 25 Mar 2024 10:21:23 +0800	[thread overview]
Message-ID: <4895695fc99558fcf5446fc56f6e84d194567c61.camel@kernel.org> (raw)
In-Reply-To: <d429bed2a6a8437c8e4705746943f8a2743a878c.camel@kernel.org>

Hi Matt,

On Thu, 2024-03-21 at 10:22 +0800, Geliang Tang wrote:
> Hi Matt,
> 
> On Mon, 2024-03-11 at 09:54 +0800, Geliang Tang wrote:
> > Hi Matt,
> > 
> > On Thu, Mar 07, 2024 at 02:59:14PM +0100, Matthieu Baerts wrote:
> > > Hello,
> > > 
> > > > From today, the CI is now validating MPTCP BPF tests!
> > 
> > Great!
> > 
> > > 
> > > To be able to do that, I got some help from Geliang (thanks!) to
> > > update
> > > the script used by the CI to launch these tests. I just did the
> > > wiring
> > > to run these tests in a new job, in parallel to the other ones,
> > > and
> > > it
> > > seems working:
> > > 
> > > https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8186843723
> > > 
> > > Please tell me if there are anything wrong with that (results,
> > > notifications, summary, etc.)
> > > 
> > > 
> > > @Geliang: it looks like the "burst" test is unstable. Do you mind
> > > looking at that please?
> > 
> > Sure, I'll check it.
> 
> I checked this. BPF tests fail sometimes with "bytes != total_bytes"
> errors. And the following patch can fix it:

I finally resolve it. It's because "burst" emits EAGAIN in this case,
we must handle it.

New patch is here:
https://patchwork.kernel.org/project/mptcp/patch/311e074a3ca0465bdc5e4c2283e334bae5ccd306.1711296000.git.tanggeliang@kylinos.cn/

Thanks,
-Geliang

> 
> https://patchwork.kernel.org/project/mptcp/patch/afe585987759af38b2547056c93d5ae8a0b1f50a.1710938175.git.tanggeliang@kylinos.cn/
> 
> Thanks,
> -Geliang
> 
> > 
> > Thanks,
> > -Geliang
> > 
> > > 
> > > 
> > > Cheers,
> > > Matt
> > > -- 
> > > Sponsored by the NGI0 Core fund.
> > 
> 


      reply	other threads:[~2024-03-25  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 13:59 CI: MPTCP BPF tests are now validated Matthieu Baerts
2024-03-11  1:54 ` Geliang Tang
2024-03-21  2:22   ` Geliang Tang
2024-03-25  2:21     ` Geliang Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4895695fc99558fcf5446fc56f6e84d194567c61.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).