From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH bpf-next 0/4] selftests/bpf: new MPTCP subflow subtest & improvements
Date: Sat, 11 May 2024 17:23:58 +0800 [thread overview]
Message-ID: <34a6fe1439ef8b6915391bb75b593a4e2805fe5a.camel@kernel.org> (raw)
In-Reply-To: <89dc0020-6bd8-4cce-8b8c-8b73c22c386e@kernel.org>
On Thu, 2024-05-09 at 16:39 +0200, Matthieu Baerts wrote:
> Hi Geliang,
>
> (only with MPTCP ML in cc)
>
> On 07/05/2024 12:53, Matthieu Baerts (NGI0) wrote:
> > In this series from Geliang, modifying MPTCP BPF selftests, we
> > have:
> >
> > - SIGINT support
> >
> > - A new macro to reduce duplicated code
> >
> > - A new MPTCP subflow BPF program setting socket options per
> > subflow: it
> > looks better to have this old test program in the BPF selftests
> > to
> > track regressions and to serve as example.
> >
> > Note: Nicolas is no longer working for Tessares, but he did this
> > work
> > while working for them, and his email address is no longer
> > available.
> >
> > - A new MPTCP BPF subtest validating the new BPF program.
> >
> > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> > ---
> > Geliang Tang (3):
> > selftests/bpf: Handle SIGINT when creating netns
>
> Regarding this patch, do you mind looking for a new version that is
> generic as requested by Alexei, please?
Sure. I'll send them to BPF ML directly and cc MPTCP ML when I finish.
Thanks,
-Geliang
>
> I guess he meant adding a new helper in network_helpers.c doing "ip
> netns add" + "signal(SIGINT)" + "open_netns()", and using it
> everywhere
> "ip netns add" + "open_netns()" are used. (I guess you will need
> another
> helper to "close_netns()" + "ip netns del" + remove the signal
> handler
> or the netns name.)
> Be careful that sometimes, more than one netns is used.
>
> > selftests/bpf: Add RUN_MPTCP_TEST macro
> > selftests/bpf: Add mptcp subflow subtest
> >
> > Nicolas Rybowski (1):
> > selftests/bpf: Add mptcp subflow example
>
> For your information, I modified our tree to apply comments from
> Alexei:
>
> New patches for t/upstream:
> - 12609b68c8d9: tg:msg: clarify the commit message
> - a4ad7c6dee6a: Revert "selftests/bpf: Add RUN_MPTCP_TEST macro"
> - f457d8911a38: conflict in t/selftests-bpf-Add-mptcp-subflow-subtest
> - 5072ff915f8d: Revert "selftests/bpf: Handle SIGINT when creating
> netns"
> - 9df135860724: conflict in t/selftests-bpf-Add-bpf-scheduler-test
> - 8ef1339edc8a: conflict in t/selftests-bpf-add-bpf_first-scheduler
> - 2f5ced304cc1: conflict in t/selftests-bpf-Add-bpf_bkup-scheduler
> - e9bafe786620: conflict in t/selftests-bpf-Add-bpf_rr-scheduler
> - dca93e3c7e9a: conflict in t/selftests-bpf-Add-bpf_red-scheduler
> - 5349d85a8c73: conflict in t/selftests-bpf-Add-bpf_burst-scheduler
> - Results: 304693999ba6..b74adae98e0d (export)
>
> Tests are now in progress:
>
> - export:
> https://github.com/multipath-tcp/mptcp_net-next/commit/715c505a46ae8394e40fdeb54e0ecea27f95dc5d/checks
>
> I will also modify the tree not to remove MPTCP_SCHED_TEST() macro as
> asked by Alexei.
>
> Cheers,
> Matt
prev parent reply other threads:[~2024-05-11 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 10:53 [PATCH bpf-next 0/4] selftests/bpf: new MPTCP subflow subtest & improvements Matthieu Baerts (NGI0)
2024-05-07 10:53 ` [PATCH bpf-next 1/4] selftests/bpf: Handle SIGINT when creating netns Matthieu Baerts (NGI0)
2024-05-07 14:43 ` Alexei Starovoitov
2024-05-07 15:59 ` Matthieu Baerts
2024-05-07 10:53 ` [PATCH bpf-next 2/4] selftests/bpf: Add RUN_MPTCP_TEST macro Matthieu Baerts (NGI0)
2024-05-07 14:44 ` Alexei Starovoitov
2024-05-07 16:02 ` Matthieu Baerts
2024-05-07 20:51 ` Alexei Starovoitov
2024-05-08 7:36 ` Matthieu Baerts
2024-05-11 1:42 ` Geliang Tang
2024-05-07 10:53 ` [PATCH bpf-next 3/4] selftests/bpf: Add mptcp subflow example Matthieu Baerts (NGI0)
2024-05-07 14:49 ` Alexei Starovoitov
2024-05-07 16:03 ` Matthieu Baerts
2024-05-07 20:54 ` Alexei Starovoitov
2024-05-08 7:36 ` Matthieu Baerts
2024-05-08 14:32 ` Alexei Starovoitov
2024-05-07 10:53 ` [PATCH bpf-next 4/4] selftests/bpf: Add mptcp subflow subtest Matthieu Baerts (NGI0)
2024-05-09 14:39 ` [PATCH bpf-next 0/4] selftests/bpf: new MPTCP subflow subtest & improvements Matthieu Baerts
2024-05-09 15:12 ` Matthieu Baerts
2024-05-11 9:23 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a6fe1439ef8b6915391bb75b593a4e2805fe5a.camel@kernel.org \
--to=geliang@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).