* [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement
@ 2017-05-11 16:22 Geert Stappers
2017-05-23 9:53 ` Geert Stappers
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Stappers @ 2017-05-11 16:22 UTC (permalink / raw
To: mlmmj
Some early exits by 'exit 0' are better of with no exit,
with just an empty statement.
---
src/mlmmj-make-ml.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mlmmj-make-ml.in b/src/mlmmj-make-ml.in
index a6e10a3..c93084f 100755
--- a/src/mlmmj-make-ml.in
+++ b/src/mlmmj-make-ml.in
@@ -146,7 +146,7 @@ if [ -n "$A_CREATE" ]; then
echo "$ALIAS" >> $ALIASFILE
;;
n|N)
- exit 0
+ : # empty statement
;;
*)
echo "Options was: y, Y, n or N"
@@ -166,7 +166,7 @@ if [ "$DO_CHOWN" ] ; then
chown -R $CHOWN $SPOOLDIR/$LISTNAME
;;
n|N)
- exit 0
+ : # empty statement
;;
*)
echo "option is: y, Y, n, N"
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement
2017-05-11 16:22 [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement Geert Stappers
@ 2017-05-23 9:53 ` Geert Stappers
2017-05-23 10:02 ` Morten Shearman Kirkegaard
2017-05-23 13:35 ` Zhang Huangbin
2 siblings, 0 replies; 4+ messages in thread
From: Geert Stappers @ 2017-05-23 9:53 UTC (permalink / raw
To: mlmmj
On Thu, May 11, 2017 at 06:22:42PM +0200, Geert Stappers wrote:
> Some early exits by 'exit 0' are better of with no exit,
> with just an empty statement.
> ---
> src/mlmmj-make-ml.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mlmmj-make-ml.in b/src/mlmmj-make-ml.in
> index a6e10a3..c93084f 100755
> --- a/src/mlmmj-make-ml.in
> +++ b/src/mlmmj-make-ml.in
> @@ -146,7 +146,7 @@ if [ -n "$A_CREATE" ]; then
> echo "$ALIAS" >> $ALIASFILE
> ;;
> n|N)
> - exit 0
> + : # empty statement
> ;;
> *)
> echo "Options was: y, Y, n or N"
> @@ -166,7 +166,7 @@ if [ "$DO_CHOWN" ] ; then
> chown -R $CHOWN $SPOOLDIR/$LISTNAME
> ;;
> n|N)
> - exit 0
> + : # empty statement
> ;;
> *)
> echo "option is: y, Y, n, N"
> --
> 2.11.0
>
>
>
Who cares?
Groeten
Geert Stappers
--
Leven en laten leven
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement
2017-05-11 16:22 [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement Geert Stappers
2017-05-23 9:53 ` Geert Stappers
@ 2017-05-23 10:02 ` Morten Shearman Kirkegaard
2017-05-23 13:35 ` Zhang Huangbin
2 siblings, 0 replies; 4+ messages in thread
From: Morten Shearman Kirkegaard @ 2017-05-23 10:02 UTC (permalink / raw
To: mlmmj
On 2017-05-23, at 11:53:21 +0200, Geert Stappers wrote:
> On Thu, May 11, 2017 at 06:22:42PM +0200, Geert Stappers wrote:
> > Some early exits by 'exit 0' are better of with no exit,
> > with just an empty statement.
...
> Who cares?
Since it doesn't fix anything, probably nobody.
// Moki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement
2017-05-11 16:22 [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement Geert Stappers
2017-05-23 9:53 ` Geert Stappers
2017-05-23 10:02 ` Morten Shearman Kirkegaard
@ 2017-05-23 13:35 ` Zhang Huangbin
2 siblings, 0 replies; 4+ messages in thread
From: Zhang Huangbin @ 2017-05-23 13:35 UTC (permalink / raw
To: mlmmj
> On May 23, 2017, at 6:02 PM, Morten Shearman Kirkegaard <moki@fabletech.com> wrote:
>
> Since it doesn't fix anything, probably nobody.
Why not merge this small patch since someone already spent his/her time to make it better?
----
Zhang Huangbin, founder of iRedMail project: http://www.iredmail.org/
Time zone: GMT+8 (China/Beijing).
Available on Telegram: https://t.me/iredmail
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-23 13:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 16:22 [mlmmj] [PATCH 1/2] src/mlmmj-make-ml.in: replaced some 'exit 0' with empty statement Geert Stappers
2017-05-23 9:53 ` Geert Stappers
2017-05-23 10:02 ` Morten Shearman Kirkegaard
2017-05-23 13:35 ` Zhang Huangbin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).