From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Baptiste Daroussin <bapt@nours.eu>
Cc: mlmmj@mlmmj.org
Subject: Re: [mlmmj] Re: bug: Index is never incremented
Date: Mon, 11 Dec 2023 13:20:59 -0500 [thread overview]
Message-ID: <20231211-monumental-ruddy-albatross-5ad294@meerkat> (raw)
In-Reply-To: <6xirowbbyhawpytmq5e3vv33bxsy7orhpyfysunyhanpasxivi@2aesfxdlzlyh>
On Sat, Dec 09, 2023 at 08:23:11PM +0100, Baptiste Daroussin wrote:
> > diff --git a/src/incindexfile.c b/src/incindexfile.c
> > index ce85fa2..33fc50e 100644
> > --- a/src/incindexfile.c
> > +++ b/src/incindexfile.c
> > @@ -51,7 +51,7 @@ int incindexfile(int listfd)
> > return 0;
> > }
> >
> > - fp = fdopen(fd, "r");
> > + fp = fdopen(fd, "r+");
> > if (fp == NULL) {
> > log_error(LOG_ARGS, "Error fdopening index file");
> > close(fd);
> >
> >
> > -K
> >
> >
>
> Thank you for the fix, I wonder why the index was not broken for my freebsd
> mailing list using it, it actually is, simply I tested on mailing list without
> archives (bummer) meaning the index does not matter much :(
Just to confirm that everything appears to be working smoothly. I will be
enabling 1.4.1 on more lists this week, including some large-volume ones. If
there are any problems, I will report.
> The testsuite was also too naive.
>
> 1.4.1 is now out fixing the issue, and the testsuite extended to be less naive
>
> Sorry about that ridiculous bug :(
Hey, no worries. :) It's one of those bugs that don't manifest themselves
unless you're doing something very specific (like sending digests).
Best regards,
-K
prev parent reply other threads:[~2023-12-11 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 16:26 [mlmmj] bug: Index is never incremented Konstantin Ryabitsev
2023-12-09 16:59 ` [mlmmj] " Konstantin Ryabitsev
2023-12-09 19:23 ` Baptiste Daroussin
2023-12-11 18:20 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211-monumental-ruddy-albatross-5ad294@meerkat \
--to=konstantin@linuxfoundation.org \
--cc=bapt@nours.eu \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).