From: "Duke Xin(辛安文)" <duke.xin@quectel.com>
To: "mani@kernel.org" <mani@kernel.org>,
"loic.poulain@linaro.org" <loic.poulain@linaro.org>,
"slark_xiao@163.com" <slark_xiao@163.com>
Cc: "fabio.porcedda@gmail.com" <fabio.porcedda@gmail.com>,
"koen.vandeputte@citymesh.com" <koen.vandeputte@citymesh.com>,
"song.fc@gmail.com" <song.fc@gmail.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"mhi@lists.linux.dev" <mhi@lists.linux.dev>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"Jerry Meng(蒙杰)" <jerry.meng@quectel.com>,
"Duke Xin(辛安文)" <duke_xinanwen@163.com>
Subject: 回复: [PATCH v6] bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem
Date: Wed, 12 Jul 2023 06:53:01 +0000 [thread overview]
Message-ID: <TY0PR06MB5053AFE3D6325CA6C0BD4A8B8436A@TY0PR06MB5053.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20230630062318.12114-1-duke_xinanwen@163.com>
Hi Mani
Excuse me, you may have forgotten to review my [PATCH v6] , please help to check it.
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
发送时间: 2023年6月30日 14:23
收件人: mani@kernel.org; loic.poulain@linaro.org; slark_xiao@163.com
抄送: fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>; Duke Xin(辛安文) <duke_xinanwen@163.com>
主题: [PATCH v6] bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem
Add MHI interface definition for RM520 product based on Qualcomm SDX6X chip
Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
Changelog
v5 -> v6
* Update commit message to include the changelog and reviewd tag.
v4 -> v5
* Add patch CC to mhi@lists.linux.dev.
v3 -> v4
* Limit character length to 75 characters and adjusted "project" description to "product".
v2 -> v3
* Sorted add rm520 id in mhi_pci_id_table and modify commit message.
v1 -> v2
* Use [modem_quectel_em1xx_config] compatible instead of duplicating the configuration.
---
drivers/bus/mhi/host/pci_generic.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 70e37c490150..1e7caa62f114 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -352,6 +352,16 @@ static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = {
.sideband_wake = true,
};
+static const struct mhi_pci_dev_info mhi_quectel_rm5xx_info = {
+ .name = "quectel-rm5xx",
+ .edl = "qcom/prog_firehose_sdx6x.elf",
+ .config = &modem_quectel_em1xx_config,
+ .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
+ .dma_data_width = 32,
+ .mru_default = 32768,
+ .sideband_wake = true,
+};
+
static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0), @@ -591,6 +601,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+ /* RM520N-GL (sdx6x), eSIM */
+ { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004),
+ .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
--
2.25.1
next parent reply other threads:[~2023-07-12 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49141a5a22d12d7539ab567cd4e7629f30-6-23163.com@g.corp-email.com>
[not found] ` <20230630062318.12114-1-duke_xinanwen@163.com>
2023-07-12 6:53 ` Duke Xin(辛安文) [this message]
2023-07-12 12:22 ` [PATCH v6] bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem Manivannan Sadhasivam
[not found] <5fcba17f46eb5e86a43e294ad9b5b67f6-6-23kernel.org@g.corp-email.com>
2023-06-06 11:31 ` Manivannan Sadhasivam
2023-06-07 11:11 ` 回复: " Duke Xin(辛安文)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY0PR06MB5053AFE3D6325CA6C0BD4A8B8436A@TY0PR06MB5053.apcprd06.prod.outlook.com \
--to=duke.xin@quectel.com \
--cc=bhelgaas@google.com \
--cc=duke_xinanwen@163.com \
--cc=fabio.porcedda@gmail.com \
--cc=jerry.meng@quectel.com \
--cc=koen.vandeputte@citymesh.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=slark_xiao@163.com \
--cc=song.fc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).