From: Manivannan Sadhasivam <mani@kernel.org>
To: "Duke Xin(辛安文)" <duke_xinanwen@163.com>
Cc: loic.poulain@linaro.org, slark_xiao@163.com,
fabio.porcedda@gmail.com, johan+linaro@kernel.org,
bhelgaas@google.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, jerry.meng@quectel.com,
duke.xin@quectel.com
Subject: Re: [PATCH v2] bus: mhi: host: pci_generic: Add support for Lenovo RM520N-GL
Date: Mon, 7 Aug 2023 12:10:06 +0530 [thread overview]
Message-ID: <20230807064006.GA18257@thinkpad> (raw)
In-Reply-To: <20230807030454.37255-1-duke_xinanwen@163.com>
On Sun, Aug 06, 2023 at 08:04:54PM -0700, Duke Xin(辛安文) wrote:
> The Quectel new RM520N-GL product works with the Quectel's existing
> RM520N-GL modem settings.But this one is designed for lenovo laptop
> usecase, hence Quectel got a new PID.
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
For this patch, I never gave my reviewed-by tag. From where did you pick this
up? It is never a good practice to add tags without permissions.
- Mani
> ---
> Changelog
>
> v1 -> v2
>
> * Adjusted description of quectel modem and limit character length to 75 characters.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index fcd80bc92978..e4f2fb67dfaf 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -604,6 +604,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> /* RM520N-GL (sdx6x), eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1004),
> .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
> + /* RM520N-GL (sdx6x), Lenovo variant */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1007),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_rm5xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
next parent reply other threads:[~2023-08-07 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230807030454.37255-1-duke_xinanwen@163.com>
2023-08-07 6:40 ` Manivannan Sadhasivam [this message]
2023-08-07 7:02 ` [PATCH v2] bus: mhi: host: pci_generic: Add support for Lenovo RM520N-GL Loic Poulain
2023-08-08 6:29 ` Manivannan Sadhasivam
2023-08-08 6:40 ` 回复: " Duke Xin(辛安文)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807064006.GA18257@thinkpad \
--to=mani@kernel.org \
--cc=bhelgaas@google.com \
--cc=duke.xin@quectel.com \
--cc=duke_xinanwen@163.com \
--cc=fabio.porcedda@gmail.com \
--cc=jerry.meng@quectel.com \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).