From: Julian Anastasov <ja@ssi.bg>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4
Date: Sat, 22 Apr 2023 13:14:13 +0300 (EEST) [thread overview]
Message-ID: <deeef4d5-208b-2d48-4714-5be1b9bc4393@ssi.bg> (raw)
In-Reply-To: <ZEMYjOlXKd+6zsgw@calendula>
Hello,
On Sat, 22 Apr 2023, Pablo Neira Ayuso wrote:
> On Mon, Apr 17, 2023 at 07:59:35PM +0300, Julian Anastasov wrote:
> >
> > On Mon, 17 Apr 2023, Simon Horman wrote:
> >
> > > this series aims to clean up IPVS in several ways without
> > > implementing any functional changes, aside from removing
> > > some debugging output.
> > >
> > > Patch 1/4: Update width of source for ip_vs_sync_conn_options
> > > The operation is safe, use an annotation to describe it properly.
> > >
> > > Patch 2/4: Consistently use array_size() in ip_vs_conn_init()
> > > It seems better to use helpers consistently.
> > >
> > > Patch 3/4: Remove {Enter,Leave}Function
> > > These seem to be well past their use-by date.
> > >
> > > Patch 4/4: Correct spelling in comments
> > > I can't spell. But codespell helps me these days.
> > >
> > > All changes: compile tested only!
> > >
> > > ---
> > > Changes in v3:
> > > - Patch 2/4: Correct division by 1024.
> > > It was applied to the wrong variable in v2.
> > > - Add Horatiu's Reviewed-by tag.
> > >
> > > Changes in v2:
> > > - Patch 1/4: Correct spelling of 'conn' in subject.
> > > - Patch 2/4: Restore division by 1024. It was lost on v1.
> > >
> > > ---
> > > Simon Horman (4):
> > > ipvs: Update width of source for ip_vs_sync_conn_options
> > > ipvs: Consistently use array_size() in ip_vs_conn_init()
> > > ipvs: Remove {Enter,Leave}Function
> > > ipvs: Correct spelling in comments
> >
> > The patchset looks good to me, thanks!
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
>
> Applied, sorry Julian, I missed your Acked-by: tag.
No problem :)
Regards
--
Julian Anastasov <ja@ssi.bg>
prev parent reply other threads:[~2023-04-22 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 15:10 [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4 Simon Horman
2023-04-17 15:10 ` [PATCH nf-next v3 1/4] ipvs: Update width of source for ip_vs_sync_conn_options Simon Horman
2023-04-17 15:10 ` [PATCH nf-next v3 2/4] ipvs: Consistently use array_size() in ip_vs_conn_init() Simon Horman
2023-04-17 15:10 ` [PATCH nf-next v3 3/4] ipvs: Remove {Enter,Leave}Function Simon Horman
2023-04-17 15:10 ` [PATCH nf-next v3 4/4] ipvs: Correct spelling in comments Simon Horman
2023-04-17 16:59 ` [PATCH nf-next v3 0/4] ipvs: Cleanups for v6.4 Julian Anastasov
2023-04-21 23:13 ` Pablo Neira Ayuso
2023-04-22 10:14 ` Julian Anastasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deeef4d5-208b-2d48-4714-5be1b9bc4393@ssi.bg \
--to=ja@ssi.bg \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).