From: Julian Anastasov <ja@ssi.bg>
To: yue longguang <yuelongguang@gmail.com>
Cc: Simon Horman <horms@verge.net.au>,
Wensong Zhang <wensong@linux-vs.org>,
pablo@netfilter.org, lvs-devel@vger.kernel.org
Subject: Re: [PATCH v3] ipvs: adjust the debug info in function set_tcp_state
Date: Sun, 27 Sep 2020 08:14:46 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.23.451.2009270807020.3858@ja.home.ssi.bg> (raw)
In-Reply-To: <CAPaK2r9th06OeNvs-1jrOq8a_ayaNL+kNWPddUUJ2GAEEJnZ8A@mail.gmail.com>
Hello,
On Sun, 27 Sep 2020, yue longguang wrote:
> Hi, could you all give me some feedback?
Feedback is same, patch is malformed on sending.
Download it from list, apply it and see what happens.
# cat /tmp/file.patch | patch -p1 --dry-run
checking file net/netfilter/ipvs/ip_vs_proto_tcp.c
patch: **** malformed patch at line 17: ip_vs_conn *cp,
If you can not resolve it, we can fix it...
> thanks
>
> On Fri, Sep 25, 2020 at 8:09 PM yue longguang <yuelongguang@gmail.com> wrote:
> >
> > From: "longguang.yue" <yuelongguang@gmail.com>
> >
> > outputting client,virtual,dst addresses info when tcp state changes,
> > which makes the connection debug more clear
> >
> > Signed-off-by: longguang.yue <yuelongguang@gmail.com>
> > ---
> > net/netfilter/ipvs/ip_vs_proto_tcp.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c
> > b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> > index dc2e7da2742a..7da51390cea6 100644
> > --- a/net/netfilter/ipvs/ip_vs_proto_tcp.c
> > +++ b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> > @@ -539,8 +539,8 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct
> > ip_vs_conn *cp,
> > if (new_state != cp->state) {
> > struct ip_vs_dest *dest = cp->dest;
> >
> > - IP_VS_DBG_BUF(8, "%s %s [%c%c%c%c] %s:%d->"
> > - "%s:%d state: %s->%s conn->refcnt:%d\n",
> > + IP_VS_DBG_BUF(8, "%s %s [%c%c%c%c] c:%s:%d v:%s:%d "
> > + "d:%s:%d state: %s->%s conn->refcnt:%d\n",
> > pd->pp->name,
> > ((state_off == TCP_DIR_OUTPUT) ?
> > "output " : "input "),
> > @@ -548,10 +548,12 @@ set_tcp_state(struct ip_vs_proto_data *pd,
> > struct ip_vs_conn *cp,
> > th->fin ? 'F' : '.',
> > th->ack ? 'A' : '.',
> > th->rst ? 'R' : '.',
> > - IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> > - ntohs(cp->dport),
> > IP_VS_DBG_ADDR(cp->af, &cp->caddr),
> > ntohs(cp->cport),
> > + IP_VS_DBG_ADDR(cp->af, &cp->vaddr),
> > + ntohs(cp->vport),
> > + IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> > + ntohs(cp->dport),
> > tcp_state_name(cp->state),
> > tcp_state_name(new_state),
> > refcount_read(&cp->refcnt));
> > --
> > 2.20.1 (Apple Git-117)
Regards
--
Julian Anastasov <ja@ssi.bg>
prev parent reply other threads:[~2020-09-27 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 12:09 [PATCH v3] ipvs: adjust the debug info in function set_tcp_state yue longguang
2020-09-27 1:56 ` yue longguang
2020-09-27 5:14 ` Julian Anastasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.23.451.2009270807020.3858@ja.home.ssi.bg \
--to=ja@ssi.bg \
--cc=horms@verge.net.au \
--cc=lvs-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
--cc=yuelongguang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).