From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Julian Anastasov <ja@ssi.bg>, Simon Horman <horms@verge.net.au>,
stable@vger.kernel.org
Subject: Re: [PATCH] ipvs: use explicitly signed chars
Date: Wed, 2 Nov 2022 09:26:52 +0100 [thread overview]
Message-ID: <Y2IpzHKuRmDA++dO@salvia> (raw)
In-Reply-To: <20221026123216.1575440-1-Jason@zx2c4.com>
On Wed, Oct 26, 2022 at 02:32:16PM +0200, Jason A. Donenfeld wrote:
> The `char` type with no explicit sign is sometimes signed and sometimes
> unsigned. This code will break on platforms such as arm, where char is
> unsigned. So mark it here as explicitly signed, so that the
> todrop_counter decrement and subsequent comparison is correct.
Applied, thanks
prev parent reply other threads:[~2022-11-02 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 12:32 [PATCH] ipvs: use explicitly signed chars Jason A. Donenfeld
2022-10-26 14:20 ` Julian Anastasov
2022-10-26 14:30 ` Jason A. Donenfeld
2022-10-26 15:01 ` Julian Anastasov
2022-11-02 2:44 ` Jason A. Donenfeld
2022-11-02 8:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2IpzHKuRmDA++dO@salvia \
--to=pablo@netfilter.org \
--cc=Jason@zx2c4.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).