lvs-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cezar Sá Espinola" <cezarsa@gmail.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: lvs-devel@vger.kernel.org
Subject: Re: Possibility of adding a new netlink command to dump everything
Date: Mon, 26 Oct 2020 16:47:46 -0300	[thread overview]
Message-ID: <CA++F93huu-Q_J2X89ndYwCGWwETmOPsDDdgVdVeDHUMU5qRg6g@mail.gmail.com> (raw)
In-Reply-To: <68d574-d213-50-7617-f1d917625362@ssi.bg>

> > 1. First of all is such a patch adding a new command something desirable and
> > could it possibly be merged or should I just drop it?
>
>         It depends on its complexity, are you changing
> the ipvsadm -S code or just the kernel part?

Thank you for the fast reply! Just the kernel part for now and some
crude standalone benchmarking code, although I intend to also change
the ipvsadm -S code to use this new cmd if available.

> > 2. I can see that besides the generic netlink interface there's also another
> > interface based on getsockopt options, should the patch also add a new socket
> > option or is it okay for this new functionality to be exclusive to generic
> > netlink?
>
>         No, sockopt is old interface and it is not changed,
> it lacks IPv6 support, etc.

Great.

> > 3. Should this go forward, any advice on my next steps? Should I simply send the
> > patch here?
>
>         You can post it with [PATCH RFC] tag, so that we
> can see how do you mix services and destinations in same
> packet. You can also add speed comparison after the --- line
> for more information.

I'll do that and we can discuss further then. Thanks a lot for your time!

Regards
--
Cezar Sá Espinola

      reply	other threads:[~2020-10-26 19:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 15:27 Possibility of adding a new netlink command to dump everything Cezar Sá Espinola
2020-10-26 19:35 ` Julian Anastasov
2020-10-26 19:47   ` Cezar Sá Espinola [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA++F93huu-Q_J2X89ndYwCGWwETmOPsDDdgVdVeDHUMU5qRg6g@mail.gmail.com \
    --to=cezarsa@gmail.com \
    --cc=ja@ssi.bg \
    --cc=lvs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).