From: "Zhouxudong (EulerOS)" <zhouxudong8@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "wensong@linux-vs.org" <wensong@linux-vs.org>,
"horms@verge.net.au" <horms@verge.net.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"lvs-devel@vger.kernel.org" <lvs-devel@vger.kernel.org>,
"Chenxiang (EulerOS)" <rose.chen@huawei.com>,
"Zhaowei (EulerOS)" <zhaowei23@huawei.com>
Subject: 答复: [PATCH] ipvs:clean code for ip_vs_sync.c
Date: Thu, 16 Jul 2020 01:03:20 +0000 [thread overview]
Message-ID: <69D1AB391AAC5746B9ECCF192D064D641A79498C@DGGEMI521-MBX.china.huawei.com> (raw)
In-Reply-To: <20200715150336.711be40a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Thank you for suggestion.
Firstly, I show an explanation for the second email.
Sorry, I forgot to CC myself in sending first email, which lead to I cannot know if it successfully.
So,I send it again.
And now, I will add a space after ipvs: in the subject and after Signed-off-by:.
-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@kernel.org]
发送时间: 2020年7月16日 6:04
收件人: Zhouxudong (EulerOS) <zhouxudong8@huawei.com>
抄送: wensong@linux-vs.org; horms@verge.net.au; netdev@vger.kernel.org; lvs-devel@vger.kernel.org; Chenxiang (EulerOS) <rose.chen@huawei.com>
主题: Re: [PATCH] ipvs:clean code for ip_vs_sync.c
On Wed, 15 Jul 2020 12:18:39 +0000 zhouxudong199 wrote:
> Signed-off-by:zhouxudong199 <zhouxudong8@huawei.com>
Thank you for the patch.
Please describe the changes you're making in the commit message, as far as I can tell you're adding missing spaces?
Please read this: https://kernelnewbies.org/KernelJanitors
and make sure to CC kernel-janitors@vger.kernel.org
Please add a space after ipvs: in the subject and after Signed-off-by:
If you repost please make sure to mark the patch as v2.
> @@ -1232,7 +1232,7 @@ static void ip_vs_process_message(struct netns_ipvs *ipvs, __u8 *buffer,
> msg_end = buffer + sizeof(struct ip_vs_sync_mesg);
> nr_conns = m2->nr_conns;
>
> - for (i=0; i<nr_conns; i++) {
> + for (i=0; i < nr_conns; i++) {
you should probably replace i=0 with i = 0.
> union ip_vs_sync_conn *s;
> unsigned int size;
> int retc;
prev parent reply other threads:[~2020-07-16 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 12:18 [PATCH] ipvs:clean code for ip_vs_sync.c zhouxudong199
2020-07-15 22:03 ` Jakub Kicinski
2020-07-16 1:03 ` Zhouxudong (EulerOS) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69D1AB391AAC5746B9ECCF192D064D641A79498C@DGGEMI521-MBX.china.huawei.com \
--to=zhouxudong8@huawei.com \
--cc=horms@verge.net.au \
--cc=kuba@kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rose.chen@huawei.com \
--cc=wensong@linux-vs.org \
--cc=zhaowei23@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).