From: Allison Henderson <allison.henderson@oracle.com>
To: "kadlec@netfilter.org" <kadlec@netfilter.org>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"tonylu@linux.alibaba.com" <tonylu@linux.alibaba.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"fw@strlen.de" <fw@strlen.de>,
"davem@davemloft.net" <davem@davemloft.net>,
"matttbe@kernel.org" <matttbe@kernel.org>,
"anna@kernel.org" <anna@kernel.org>,
"trond.myklebust@hammerspace.com"
<trond.myklebust@hammerspace.com>,
"tom@talpey.com" <tom@talpey.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"ms@dev.tdt.de" <ms@dev.tdt.de>,
"stefan@datenfreihafen.org" <stefan@datenfreihafen.org>,
"lucien.xin@gmail.com" <lucien.xin@gmail.com>,
"ying.xue@windriver.com" <ying.xue@windriver.com>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"marc.dionne@auristor.com" <marc.dionne@auristor.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"geliang@kernel.org" <geliang@kernel.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>, Dai Ngo <dai.ngo@oracle.com>,
"jmaloy@redhat.com" <jmaloy@redhat.com>,
"alex.aring@gmail.com" <alex.aring@gmail.com>,
"ja@ssi.bg" <ja@ssi.bg>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"horms@verge.net.au" <horms@verge.net.au>,
"j.granados@samsung.com" <j.granados@samsung.com>,
"kolga@netapp.com" <kolga@netapp.com>,
"courmisch@gmail.com" <courmisch@gmail.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"martineau@kernel.org" <martineau@kernel.org>,
"roopa@nvidia.com" <roopa@nvidia.com>,
"wenjia@linux.ibm.com" <wenjia@linux.ibm.com>,
"edumazet@google.com" <edumazet@google.com>,
"razor@blackwall.org" <razor@blackwall.org>,
"jaka@linux.ibm.com" <jaka@linux.ibm.com>,
"jreuter@yaina.de" <jreuter@yaina.de>,
"guwen@linux.alibaba.com" <guwen@linux.alibaba.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"marcelo.leitner@gmail.com" <marcelo.leitner@gmail.com>,
Chuck Lever III <chuck.lever@oracle.com>,
"neilb@suse.de" <neilb@suse.de>,
"alibuda@linux.alibaba.com" <alibuda@linux.alibaba.com>
Cc: "tipc-discussion@lists.sourceforge.net"
<tipc-discussion@lists.sourceforge.net>,
"bridge@lists.linux.dev" <bridge@lists.linux.dev>,
"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
"dccp@vger.kernel.org" <dccp@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
"linux-hams@vger.kernel.org" <linux-hams@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-x25@vger.kernel.org" <linux-x25@vger.kernel.org>,
"lvs-devel@vger.kernel.org" <lvs-devel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-afs@lists.infradead.org" <linux-afs@lists.infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-wpan@vger.kernel.org" <linux-wpan@vger.kernel.org>,
"mptcp@lists.linux.dev" <mptcp@lists.linux.dev>
Subject: Re: [PATCH net-next v6 3/8] net: rds: Remove the now superfluous sentinel elements from ctl_table array
Date: Fri, 3 May 2024 02:27:22 +0000 [thread overview]
Message-ID: <4a2154ccbf8e0e73f09e717d49864eb1003d5cfa.camel@oracle.com> (raw)
In-Reply-To: <20240501-jag-sysctl_remset_net-v6-3-370b702b6b4a@samsung.com>
On Wed, 2024-05-01 at 11:29 +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@samsung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/
> )
>
> * Remove sentinel element from ctl_table structs.
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
These changes look fine to me. Thank you!
Acked-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> net/rds/ib_sysctl.c | 1 -
> net/rds/sysctl.c | 1 -
> net/rds/tcp.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c
> index e4e41b3afce7..2af678e71e3c 100644
> --- a/net/rds/ib_sysctl.c
> +++ b/net/rds/ib_sysctl.c
> @@ -103,7 +103,6 @@ static struct ctl_table rds_ib_sysctl_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec,
> },
> - { }
> };
>
> void rds_ib_sysctl_exit(void)
> diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c
> index e381bbcd9cc1..025f518a4349 100644
> --- a/net/rds/sysctl.c
> +++ b/net/rds/sysctl.c
> @@ -89,7 +89,6 @@ static struct ctl_table rds_sysctl_rds_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec,
> },
> - { }
> };
>
> void rds_sysctl_exit(void)
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index 2dba7505b414..d8111ac83bb6 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -86,7 +86,6 @@ static struct ctl_table rds_tcp_sysctl_table[] = {
> .proc_handler = rds_tcp_skbuf_handler,
> .extra1 = &rds_tcp_min_rcvbuf,
> },
> - { }
> };
>
> u32 rds_tcp_write_seq(struct rds_tcp_connection *tc)
>
next prev parent reply other threads:[~2024-05-03 2:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 9:29 [PATCH net-next v6 0/8] sysctl: Remove sentinel elements from networking Joel Granados via B4 Relay
2024-05-01 9:29 ` [PATCH net-next v6 1/8] net: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-05-03 12:40 ` patchwork-bot+netdevbpf
2024-05-01 9:29 ` [PATCH net-next v6 2/8] net: ipv{6,4}: " Joel Granados via B4 Relay
2024-05-01 9:29 ` [PATCH net-next v6 3/8] net: rds: " Joel Granados via B4 Relay
2024-05-03 2:27 ` Allison Henderson [this message]
2024-05-01 9:29 ` [PATCH net-next v6 4/8] net: sunrpc: " Joel Granados via B4 Relay
2024-05-01 9:29 ` [PATCH net-next v6 5/8] net: Remove ctl_table sentinel elements from several networking subsystems Joel Granados via B4 Relay
2024-05-01 9:29 ` [PATCH net-next v6 6/8] netfilter: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-05-01 9:29 ` [PATCH net-next v6 7/8] appletalk: " Joel Granados via B4 Relay
2024-05-01 9:29 ` [PATCH net-next v6 8/8] ax.25: x.25: " Joel Granados via B4 Relay
2024-05-01 13:15 ` Sabrina Dubroca
2024-05-03 12:18 ` Joel Granados
2024-05-03 15:23 ` Dan Carpenter
2024-05-07 8:02 ` Joel Granados
2024-05-01 13:22 ` [PATCH net-next v6 0/8] sysctl: Remove sentinel elements from networking Sabrina Dubroca
2024-05-03 12:20 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a2154ccbf8e0e73f09e717d49864eb1003d5cfa.camel@oracle.com \
--to=allison.henderson@oracle.com \
--cc=alex.aring@gmail.com \
--cc=alibuda@linux.alibaba.com \
--cc=anna@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=chuck.lever@oracle.com \
--cc=coreteam@netfilter.org \
--cc=courmisch@gmail.com \
--cc=dai.ngo@oracle.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=guwen@linux.alibaba.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=j.granados@samsung.com \
--cc=ja@ssi.bg \
--cc=jaka@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jmaloy@redhat.com \
--cc=jreuter@yaina.de \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=lvs-devel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=marcelo.leitner@gmail.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mcgrof@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mptcp@lists.linux.dev \
--cc=ms@dev.tdt.de \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=ralf@linux-mips.org \
--cc=razor@blackwall.org \
--cc=rds-devel@oss.oracle.com \
--cc=roopa@nvidia.com \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tom@talpey.com \
--cc=tonylu@linux.alibaba.com \
--cc=trond.myklebust@hammerspace.com \
--cc=wenjia@linux.ibm.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).