From: Joanne Koong <joannekoong@fb.com>
To: CGEL <cgel.zte@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, alex.aring@gmail.com,
stefan@datenfreihafen.org, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, horms@verge.net.au, ja@ssi.bg,
pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
daniel@iogearbox.net, roopa@nvidia.com, yajun.deng@linux.dev,
chinagar@codeaurora.org, xu.xin16@zte.com.cn,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wpan@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH net-next] net: Enable some sysctls for the userns root with privilege
Date: Tue, 7 Dec 2021 14:16:43 -0800 [thread overview]
Message-ID: <2f0757f8-797f-644b-50ee-0c1aef8fe865@fb.com> (raw)
In-Reply-To: <61af0ac4.1c69fb81.6badc.a755@mx.google.com>
On 12/6/21 11:18 PM, CGEL wrote:
> On Mon, Dec 06, 2021 at 04:45:20PM -0800, Jakub Kicinski wrote:
>> On Fri, 3 Dec 2021 03:28:15 +0000 cgel.zte@gmail.com wrote:
>>> From: xu xin <xu.xin16@zte.com.cn>
>>>
>>> Enabled sysctls include the followings:
>>> 1. net/ipv4/neigh/<if>/*
>>> 2. net/ipv6/neigh/<if>/*
>>> 3. net/ieee802154/6lowpan/*
>>> 4. net/ipv6/route/*
>>> 5. net/ipv4/vs/*
>>> 6. net/unix/*
>>> 7. net/core/xfrm_*
>>>
>>> In practical work, some userns with root privilege have needs to adjust
>>> these sysctls in their own netns, but limited just because they are not
>>> init user_ns, even if they are given root privilege by docker -privilege.
>> You need to justify why removing these checks is safe. It sounds like
>> you're only describing why having the permissions is problematic, which
>> is fair but not sufficient to just remove them.
>>
> Hi, Jakub
> My patch is a little radical. I just saw Eric's previous reply to
> Alexander(https://lore.kernel.org/all/87pmsqyuqy.fsf@disp2133/).
> These were disabled because out of an abundance of caution.
>
> My original intention is to enable part of syscyls about neighbor which
> I think was safe, but I will try to figure out which of these sysctls
> are safe to be enabled.
>
A team at my company has a use case for needing to set the unix sysctls,
so I submitted a patch for enabling the unix sysctl here
https://lore.kernel.org/netdev/20211207202101.2457994-1-joannekoong@fb.com/T/#u
[...]
>>> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
>>> ---
>>> net/core/neighbour.c | 4 ----
>>> net/ieee802154/6lowpan/reassembly.c | 4 ----
>>> net/ipv6/route.c | 4 ----
>>> net/netfilter/ipvs/ip_vs_ctl.c | 4 ----
>>> net/netfilter/ipvs/ip_vs_lblc.c | 4 ----
>>> net/netfilter/ipvs/ip_vs_lblcr.c | 3 ---
>>> net/unix/sysctl_net_unix.c | 4 ----
>>> net/xfrm/xfrm_sysctl.c | 4 ----
>>> 8 files changed, 31 deletions(-)
>
prev parent reply other threads:[~2021-12-07 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 3:28 [PATCH net-next] net: Enable some sysctls for the userns root with privilege cgel.zte
2021-12-07 0:45 ` Jakub Kicinski
2021-12-07 7:18 ` CGEL
2021-12-07 22:16 ` Joanne Koong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0757f8-797f-644b-50ee-0c1aef8fe865@fb.com \
--to=joannekoong@fb.com \
--cc=alex.aring@gmail.com \
--cc=cgel.zte@gmail.com \
--cc=chinagar@codeaurora.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=roopa@nvidia.com \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=xu.xin16@zte.com.cn \
--cc=yajun.deng@linux.dev \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).