From: Joel Granados <j.granados@samsung.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
<devnull+j.granados.samsung.com@kernel.org>, <Dai.Ngo@oracle.com>,
<alex.aring@gmail.com>, <alibuda@linux.alibaba.com>,
<allison.henderson@oracle.com>, <anna@kernel.org>,
<bridge@lists.linux.dev>, <chuck.lever@oracle.com>,
<coreteam@netfilter.org>, <courmisch@gmail.com>,
<davem@davemloft.net>, <dccp@vger.kernel.org>,
<dhowells@redhat.com>, <dsahern@kernel.org>,
<edumazet@google.com>, <fw@strlen.de>, <geliang@kernel.org>,
<guwen@linux.alibaba.com>, <herbert@gondor.apana.org.au>,
<horms@verge.net.au>, <ja@ssi.bg>, <jaka@linux.ibm.com>,
<jlayton@kernel.org>, <jmaloy@redhat.com>, <jreuter@yaina.de>,
<kadlec@netfilter.org>, <keescook@chromium.org>,
<kolga@netapp.com>, <kuba@kernel.org>,
<linux-afs@lists.infradead.org>, <linux-hams@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<linux-sctp@vger.kernel.org>, <linux-wpan@vger.kernel.org>,
<linux-x25@vger.kernel.org>, <lucien.xin@gmail.com>,
<lvs-devel@vger.kernel.org>, <marc.dionne@auristor.com>,
<marcelo.leitner@gmail.com>, <martineau@kernel.org>,
<matttbe@kernel.org>, <mcgrof@kernel.org>,
<miquel.raynal@bootlin.com>, <mptcp@lists.linux.dev>,
<ms@dev.tdt.de>, <neilb@suse.de>, <netdev@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>, <pablo@netfilter.org>,
<ralf@linux-mips.org>, <razor@blackwall.org>,
<rds-devel@oss.oracle.com>, <roopa@nvidia.com>,
<stefan@datenfreihafen.org>, <steffen.klassert@secunet.com>,
<tipc-discussion@lists.sourceforge.net>, <tom@talpey.com>,
<tonylu@linux.alibaba.com>, <trond.myklebust@hammerspace.com>,
<wenjia@linux.ibm.com>, <ying.xue@windriver.com>
Subject: Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array
Date: Tue, 16 Apr 2024 14:32:12 +0200 [thread overview]
Message-ID: <20240416123212.nrgpuix3dhkmfbzq@joelS2.panther.com> (raw)
In-Reply-To: <be056435353af60a564f457c79dacc16c6ea920e.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On Tue, Apr 16, 2024 at 10:18:42AM +0200, Paolo Abeni wrote:
> On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote:
> > From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@kernel.org>
> > Date: Fri, 12 Apr 2024 16:48:29 +0200
> > > From: Joel Granados <j.granados@samsung.com>
...
> > > net/rxrpc/sysctl.c | 1 -
> > > net/sctp/sysctl.c | 6 +-----
> > > net/smc/smc_sysctl.c | 1 -
> > > net/sunrpc/sysctl.c | 1 -
> > > net/sunrpc/xprtrdma/svc_rdma.c | 1 -
> > > net/sunrpc/xprtrdma/transport.c | 1 -
> > > net/sunrpc/xprtsock.c | 1 -
> > > net/tipc/sysctl.c | 1 -
> > > net/unix/sysctl_net_unix.c | 1 -
> > > net/x25/sysctl_net_x25.c | 1 -
> > > net/xfrm/xfrm_sysctl.c | 5 +----
> > > 35 files changed, 20 insertions(+), 81 deletions(-)
> >
> > You may want to split patch based on subsystem or the type of changes
> > to make review easier.
>
> I agree with Kuniyuki. I think the x25 chunks can me moved in the last
> patch, and at least sunrpc and rds could go in separate patches,
> possibly even xfrm and smc.
No problem. I'll put x25 and ax.25 patches together into one commit.
Thx
Best
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-04-16 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 14:48 [PATCH v3 0/4] sysctl: Remove sentinel elements from networking Joel Granados via B4 Relay
2024-04-12 14:48 ` [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-04-15 23:12 ` Kuniyuki Iwashima
2024-04-16 8:18 ` Paolo Abeni
2024-04-16 12:32 ` Joel Granados [this message]
2024-04-16 9:45 ` Joel Granados
2024-04-12 14:48 ` [PATCH v3 2/4] netfilter: " Joel Granados via B4 Relay
2024-04-12 14:48 ` [PATCH v3 3/4] appletalk: " Joel Granados via B4 Relay
2024-04-12 14:48 ` [PATCH v3 4/4] ax.25: " Joel Granados via B4 Relay
2024-04-15 23:18 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416123212.nrgpuix3dhkmfbzq@joelS2.panther.com \
--to=j.granados@samsung.com \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=alibuda@linux.alibaba.com \
--cc=allison.henderson@oracle.com \
--cc=anna@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=chuck.lever@oracle.com \
--cc=coreteam@netfilter.org \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=devnull+j.granados.samsung.com@kernel.org \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=guwen@linux.alibaba.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=jaka@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jmaloy@redhat.com \
--cc=jreuter@yaina.de \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=lvs-devel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=marcelo.leitner@gmail.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mcgrof@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mptcp@lists.linux.dev \
--cc=ms@dev.tdt.de \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=ralf@linux-mips.org \
--cc=razor@blackwall.org \
--cc=rds-devel@oss.oracle.com \
--cc=roopa@nvidia.com \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tom@talpey.com \
--cc=tonylu@linux.alibaba.com \
--cc=trond.myklebust@hammerspace.com \
--cc=wenjia@linux.ibm.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).