From: Leon Romanovsky <leonro@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Eric Dumazet <edumazet@google.com>
Cc: coreteam@netfilter.org, Florian Westphal <fw@strlen.de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Julian Anastasov <ja@ssi.bg>,
lvs-devel@vger.kernel.org, Matteo Croce <mcroce@redhat.com>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH net-next v1 3/4] net/core: move gro function declarations to separate header
Date: Wed, 3 Feb 2021 15:22:43 +0200 [thread overview]
Message-ID: <20210203132243.GM3264866@unreal> (raw)
In-Reply-To: <20210203101612.4004322-4-leon@kernel.org>
On Wed, Feb 03, 2021 at 12:16:11PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Fir the following compilation warnings:
> 1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb)
>
> net/ipv6/ip6_offload.c:182:41: warning: no previous prototype for ‘ipv6_gro_receive’ [-Wmissing-prototypes]
> 182 | INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
> | ^~~~~~~~~~~~~~~~
> net/ipv6/ip6_offload.c:320:29: warning: no previous prototype for ‘ipv6_gro_complete’ [-Wmissing-prototypes]
> 320 | INDIRECT_CALLABLE_SCOPE int ipv6_gro_complete(struct sk_buff *skb, int nhoff)
> | ^~~~~~~~~~~~~~~~~
> net/ipv6/ip6_offload.c:182:41: warning: no previous prototype for ‘ipv6_gro_receive’ [-Wmissing-prototypes]
> 182 | INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
> | ^~~~~~~~~~~~~~~~
> net/ipv6/ip6_offload.c:320:29: warning: no previous prototype for ‘ipv6_gro_complete’ [-Wmissing-prototypes]
> 320 | INDIRECT_CALLABLE_SCOPE int ipv6_gro_complete(struct sk_buff *skb, int nhoff)
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> include/net/gro.h | 12 ++++++++++++
> net/core/dev.c | 7 +------
> 2 files changed, 13 insertions(+), 6 deletions(-)
> create mode 100644 include/net/gro.h
I sent it too fast, sorry for that.
There is a need to add #include <net/gro.h> to the ip6_offload.c.
I will resend.
Thanks
next prev parent reply other threads:[~2021-02-03 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 10:16 [PATCH net-next v1 0/4] Fix W=1 compilation warnings in net/* folder Leon Romanovsky
2021-02-03 10:16 ` [PATCH net-next v1 1/4] ipv6: silence compilation warning for non-IPV6 builds Leon Romanovsky
2021-02-03 10:16 ` [PATCH net-next v1 2/4] ipv6: move udp declarations to net/udp.h Leon Romanovsky
2021-02-03 10:16 ` [PATCH net-next v1 3/4] net/core: move gro function declarations to separate header Leon Romanovsky
2021-02-03 13:22 ` Leon Romanovsky [this message]
2021-02-03 10:16 ` [PATCH net-next v1 4/4] netfilter: move handlers to net/ip_vs.h Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203132243.GM3264866@unreal \
--to=leonro@nvidia.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).