From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Zhouxudong (EulerOS)" <zhouxudong8@huawei.com>
Cc: Suraj Upadhyay <usuraj35@gmail.com>,
"wensong@linux-vs.org" <wensong@linux-vs.org>,
"horms@verge.net.au" <horms@verge.net.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"lvs-devel@vger.kernel.org" <lvs-devel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"Chenxiang (EulerOS)" <rose.chen@huawei.com>,
"Zhaowei (EulerOS)" <zhaowei23@huawei.com>
Subject: Re: 答复: [PATCH v2] ipvs: clean code for ip_vs_sync.c
Date: Thu, 16 Jul 2020 13:23:22 +0300 [thread overview]
Message-ID: <20200716102321.GC2549@kadam> (raw)
In-Reply-To: <69D1AB391AAC5746B9ECCF192D064D641A7949E1@DGGEMI521-MBX.china.huawei.com>
It's probably better to start somewhere like drivers/staging for clean
up work. Networking people are pretty busy with their own things but
staging is happy to take clean up patches.
You need to use a proper legal name (like you would for signing
documents for your From and Signed-off-by.
> > @@ -1444,7 +1444,7 @@ static int bind_mcastif_addr(struct socket *sock, struct net_device *dev)
> > sin.sin_addr.s_addr = addr;
> > sin.sin_port = 0;
>
> I think you missed this one.
> should be
> - sin.sin_port = 0;
> + sin.sin_port = 0
That was done deliberately. Just leave that one as-is, please.
regards,
dan carpenter
prev parent reply other threads:[~2020-07-16 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 1:57 [PATCH v2] ipvs: clean code for ip_vs_sync.c zhouxudong199
2020-07-16 2:46 ` Suraj Upadhyay
2020-07-16 2:59 ` 答复: " Zhouxudong (EulerOS)
2020-07-16 10:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716102321.GC2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=horms@verge.net.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rose.chen@huawei.com \
--cc=usuraj35@gmail.com \
--cc=wensong@linux-vs.org \
--cc=zhaowei23@huawei.com \
--cc=zhouxudong8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).