From: zhouxudong199 <zhouxudong8@huawei.com>
To: wensong@linux-vs.org, horms@verge.net.au
Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org, zhouxudong8@huawei.com,
rose.chen@huawei.com, zhaowei23@huawei.com
Subject: [PATCH v3] ipvs: clean code for ip_vs_sync.c
Date: Thu, 16 Jul 2020 02:57:38 +0000 [thread overview]
Message-ID: <1594868258-37160-1-git-send-email-zhouxudong8@huawei.com> (raw)
Use appropriate spaces around operators.
Signed-off-by: zhouxudong199 <zhouxudong8@huawei.com>
---
v1 -> v2:
add missing spaces after Signed-off-by and ipvs: in the subject.
i=0 changed to i = 0.
v2 -> v3:
move version changes after Signed-off-by.
change commit messages
net/netfilter/ipvs/ip_vs_sync.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index 605e0f6..885bab4 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -1077,10 +1077,10 @@ static inline int ip_vs_proc_sync_conn(struct netns_ipvs *ipvs, __u8 *p, __u8 *m
struct ip_vs_protocol *pp;
struct ip_vs_conn_param param;
__u32 flags;
- unsigned int af, state, pe_data_len=0, pe_name_len=0;
- __u8 *pe_data=NULL, *pe_name=NULL;
- __u32 opt_flags=0;
- int retc=0;
+ unsigned int af, state, pe_data_len = 0, pe_name_len = 0;
+ __u8 *pe_data = NULL, *pe_name = NULL;
+ __u32 opt_flags = 0;
+ int retc = 0;
s = (union ip_vs_sync_conn *) p;
@@ -1089,7 +1089,7 @@ static inline int ip_vs_proc_sync_conn(struct netns_ipvs *ipvs, __u8 *p, __u8 *m
af = AF_INET6;
p += sizeof(struct ip_vs_sync_v6);
#else
- IP_VS_DBG(3,"BACKUP, IPv6 msg received, and IPVS is not compiled for IPv6\n");
+ IP_VS_DBG(3, "BACKUP, IPv6 msg received, and IPVS is not compiled for IPv6\n");
retc = 10;
goto out;
#endif
@@ -1129,7 +1129,7 @@ static inline int ip_vs_proc_sync_conn(struct netns_ipvs *ipvs, __u8 *p, __u8 *m
break;
case IPVS_OPT_PE_NAME:
- if (ip_vs_proc_str(p, plen,&pe_name_len, &pe_name,
+ if (ip_vs_proc_str(p, plen, &pe_name_len, &pe_name,
IP_VS_PENAME_MAXLEN, &opt_flags,
IPVS_OPT_F_PE_NAME))
return -70;
@@ -1155,7 +1155,7 @@ static inline int ip_vs_proc_sync_conn(struct netns_ipvs *ipvs, __u8 *p, __u8 *m
if (!(flags & IP_VS_CONN_F_TEMPLATE)) {
pp = ip_vs_proto_get(s->v4.protocol);
if (!pp) {
- IP_VS_DBG(3,"BACKUP, Unsupported protocol %u\n",
+ IP_VS_DBG(3, "BACKUP, Unsupported protocol %u\n",
s->v4.protocol);
retc = 30;
goto out;
@@ -1232,7 +1232,7 @@ static void ip_vs_process_message(struct netns_ipvs *ipvs, __u8 *buffer,
msg_end = buffer + sizeof(struct ip_vs_sync_mesg);
nr_conns = m2->nr_conns;
- for (i=0; i<nr_conns; i++) {
+ for (i = 0; i < nr_conns; i++) {
union ip_vs_sync_conn *s;
unsigned int size;
int retc;
@@ -1444,7 +1444,7 @@ static int bind_mcastif_addr(struct socket *sock, struct net_device *dev)
sin.sin_addr.s_addr = addr;
sin.sin_port = 0;
- return sock->ops->bind(sock, (struct sockaddr*)&sin, sizeof(sin));
+ return sock->ops->bind(sock, (struct sockaddr *)&sin, sizeof(sin));
}
static void get_mcast_sockaddr(union ipvs_sockaddr *sa, int *salen,
--
2.6.1.windows.1
reply other threads:[~2020-07-16 2:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594868258-37160-1-git-send-email-zhouxudong8@huawei.com \
--to=zhouxudong8@huawei.com \
--cc=horms@verge.net.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rose.chen@huawei.com \
--cc=wensong@linux-vs.org \
--cc=zhaowei23@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).