From: "wanghai (M)" <wanghai38@huawei.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: horms@verge.net.au, pablo@netfilter.org, kadlec@netfilter.org,
fw@strlen.de, davem@davemloft.net, kuba@kernel.org,
christian@brauner.io, hans.schillstrom@ericsson.com,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init
Date: Fri, 20 Nov 2020 16:29:52 +0800 [thread overview]
Message-ID: <0574c34c-60a8-8d8d-38b1-962898e55801@huawei.com> (raw)
In-Reply-To: <f111e78-b9c1-453-c6e5-a063e62cd83b@ssi.bg>
ÔÚ 2020/11/20 2:22, Julian Anastasov дµÀ:
> Hello,
>
> On Thu, 19 Nov 2020, Wang Hai wrote:
>
>> kmemleak report a memory leak as follows:
>>
>> BUG: memory leak
>> unreferenced object 0xffff8880759ea000 (size 256):
>> comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s)
>> hex dump (first 32 bytes):
>> 00 00 00 00 01 00 00 00 08 a0 9e 75 80 88 ff ff ...........u....
[...]
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>> ---
>> net/netfilter/ipvs/ip_vs_ctl.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
>> index e279ded4e306..d99bb89e7c25 100644
>> --- a/net/netfilter/ipvs/ip_vs_ctl.c
>> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
>> @@ -4180,6 +4180,9 @@ int __net_init ip_vs_control_net_init(struct netns_ipvs *ipvs)
>> return 0;
> May be we should add some #ifdef CONFIG_PROC_FS because
> proc_create_net* return NULL when PROC is not used. For example:
>
> #ifdef CONFIG_PROC_FS
> if (!proc_create_net...
> goto err_vs;
> if (!proc_create_net...
> goto err_stats;
> ...
> #endif
> ...
>
>> err:
> #ifdef CONFIG_PROC_FS
>> + remove_proc_entry("ip_vs_stats_percpu", ipvs->net->proc_net);
> err_percpu:
>> + remove_proc_entry("ip_vs_stats", ipvs->net->proc_net);
> err_stats:
>> + remove_proc_entry("ip_vs", ipvs->net->proc_net);
> err_vs:
> #endif
>
>> free_percpu(ipvs->tot_stats.cpustats);
>> return -ENOMEM;
>> }
>> --
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
> .
Thanks for your advice, I just sent v2
¡°[PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_init¡±
>
prev parent reply other threads:[~2020-11-20 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 10:41 [PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init Wang Hai
2020-11-19 18:22 ` Julian Anastasov
2020-11-20 8:29 ` wanghai (M) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0574c34c-60a8-8d8d-38b1-962898e55801@huawei.com \
--to=wanghai38@huawei.com \
--cc=christian@brauner.io \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hans.schillstrom@ericsson.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).