From: David Teigland (@teigland) <gitlab@mg.gitlab.com>
To: lvm-devel@redhat.com
Subject: [Git][lvmteam/lvm2][main] device_id: fix lvmdevices update segfault
Date: Fri, 06 Oct 2023 17:25:51 +0000 [thread overview]
Message-ID: <6520431f5bad0_2aa53349051f@gitlab-sidekiq-low-urgency-cpu-bound-v2-845b4dd648-85wf5.mail> (raw)
David Teigland pushed to branch main at LVM team / lvm2
Commits:
25a87ea1 by David Teigland at 2023-10-06T12:24:34-05:00
device_id: fix lvmdevices update segfault
>From commit 1901a47df12
"device_id: fix conditions for device_ids_refresh"
- - - - -
1 changed file:
- lib/device/device_id.c
Changes:
=====================================
lib/device/device_id.c
=====================================
@@ -2546,7 +2546,8 @@ void device_ids_validate(struct cmd_context *cmd, struct dm_list *scanned_devs,
dev = du->dev;
devname = dev_name(du->dev);
- if (!device_list_find_dev(scanned_devs, du->dev) || (du->dev->flags & DEV_SCAN_NOT_READ)) {
+ if ((scanned_devs && !device_list_find_dev(scanned_devs, du->dev)) ||
+ (du->dev->flags & DEV_SCAN_NOT_READ)) {
log_debug("Validate %s %s PVID %s on %s: not scanned",
idtype_to_str(du->idtype), du->idname ?: ".", du->pvid ?: ".", devname);
} else {
View it on GitLab: https://gitlab.com/lvmteam/lvm2/-/commit/25a87ea16aba335b5f33621cd5ac6ff651f0bbb1
--
View it on GitLab: https://gitlab.com/lvmteam/lvm2/-/commit/25a87ea16aba335b5f33621cd5ac6ff651f0bbb1
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20231006/8cd6ab23/attachment.htm>
reply other threads:[~2023-10-06 17:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6520431f5bad0_2aa53349051f@gitlab-sidekiq-low-urgency-cpu-bound-v2-845b4dd648-85wf5.mail \
--to=gitlab@mg.gitlab.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).