From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: Duncan Sands <baldrick@free.fr>, lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] Compile fix for urcu-bp.c
Date: Mon, 1 Apr 2024 10:03:53 -0400 [thread overview]
Message-ID: <cb341ad4-1888-4d34-9da3-636d6d8036bd@efficios.com> (raw)
In-Reply-To: <c0fa14f8-2771-4597-9232-0438a67badca@free.fr>
Hi,
There are a few things missing before I can take this patch:
- Missing commit message describing the issue,
- Missing "Signed-off-by" tag.
Thanks!
Mathieu
On 2024-03-29 10:06, Duncan Sands via lttng-dev wrote:
> --- src/urcu-bp.c
> +++ src/urcu-bp.c
> @@ -409,7 +409,7 @@ void expand_arena(struct registry_arena *arena)
> new_chunk_size_bytes, 0);
> if (new_chunk != MAP_FAILED) {
> /* Should not have moved. */
> - assert(new_chunk == last_chunk);
> + urcu_posix_assert(new_chunk == last_chunk);
> memset((char *) last_chunk + old_chunk_size_bytes, 0,
> new_chunk_size_bytes - old_chunk_size_bytes);
> last_chunk->capacity = new_capacity;
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
prev parent reply other threads:[~2024-04-01 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 14:06 [lttng-dev] Compile fix for urcu-bp.c Duncan Sands via lttng-dev
2024-04-01 14:03 ` Mathieu Desnoyers via lttng-dev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb341ad4-1888-4d34-9da3-636d6d8036bd@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=baldrick@free.fr \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).