From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: "Beckius, Mikael" <mikael.beckius@windriver.com>,
"lttng-dev@lists.lttng.org" <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] lttng-consumerd crash on aarch64 due to x86 arch specific optimization
Date: Mon, 6 Feb 2023 11:39:29 -0500 [thread overview]
Message-ID: <0a2ea00d-5ff6-ba0a-cb99-0e1d2625cfd4@efficios.com> (raw)
In-Reply-To: <PH0PR11MB49043811E60B4E2AE3C58EBD92DA9@PH0PR11MB4904.namprd11.prod.outlook.com>
Hi Micke,
I did tweaks to make the code C++ compatible even though it's currently
only built in C. It makes it more future-proof.
I've merged the resulting patch into lttng-ust
master/stable-2.13/stable-2.12. Thanks for testing !
Mathieu
On 2023-02-06 11:15, Beckius, Mikael wrote:
> Hello Mathieu!
>
> I added your latest implementation to my test and it seems to perform well on both arm and arm64. Since the test was written in C++ I had to make a small change to the cast in order for the test to compile.
>
> Micke
>
>> -----Ursprungligt meddelande-----
>> Från: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> Skickat: den 2 februari 2023 17:26
>> Till: Beckius, Mikael <mikael.beckius@windriver.com>; lttng-
>> dev@lists.lttng.org
>> Ämne: Re: [lttng-dev] lttng-consumerd crash on aarch64 due to x86 arch
>> specific optimization
>>
>> CAUTION: This email comes from a non Wind River email account!
>> Do not click links or open attachments unless you recognize the sender and
>> know the content is safe.
>>
>> Hi Mikael,
>>
>> I just tried another approach to fix this issue, see:
>>
>> https://review.lttng.org/c/lttng-ust/+/9413 Fix: use unaligned pointer
>> accesses for lttng_inline_memcpy
>>
>> It is less intrusive than other approaches, and does not change the generated
>> code on the
>> most relevant architectures.
>>
>> Feedback is welcome,
>>
>> Thanks,
>>
>> Mathieu
>>
>>
>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
>> https://www.efficios.com
>
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2023-02-06 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 6:50 [lttng-dev] lttng-consumerd crash on aarch64 due to x86 arch specific optimization Beckius, Mikael via lttng-dev
2023-01-31 16:08 ` Mathieu Desnoyers via lttng-dev
2023-01-31 16:18 ` Mathieu Desnoyers via lttng-dev
2023-01-31 16:32 ` Mathieu Desnoyers via lttng-dev
2023-02-02 16:26 ` Mathieu Desnoyers via lttng-dev
2023-02-06 15:21 ` Beckius, Mikael via lttng-dev
2023-02-06 16:15 ` Beckius, Mikael via lttng-dev
2023-02-06 16:39 ` Mathieu Desnoyers via lttng-dev [this message]
[not found] <CAF2baFfZ+sxAGfxGY_or7=JJMxDngZTtfrzruUC5=RnZFD4tvA@mail.gmail.com>
[not found] ` <954909194.21985.1511551181212.JavaMail.zimbra@efficios.com>
[not found] ` <CAF2baFecVMCenooHSMcNChMEkevz1taF0VWUxWAyxbUq8kVXSg@mail.gmail.com>
2023-01-25 12:25 ` Mathieu Desnoyers via lttng-dev
2023-01-26 19:32 ` Anders Wallin via lttng-dev
2023-01-26 19:47 ` Mathieu Desnoyers via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a2ea00d-5ff6-ba0a-cb99-0e1d2625cfd4@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mikael.beckius@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).