From: Li Wang <liwang@redhat.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] Rewrite fcnt14 test
Date: Fri, 10 May 2024 10:27:46 +0800 [thread overview]
Message-ID: <CAEemH2cn5SwErswkQgsDFSP26DZtDMHnu_HAtKmFm5nV97eWOA@mail.gmail.com> (raw)
In-Reply-To: <20240509102001.GA243374@pevik>
On Thu, May 9, 2024 at 6:20 PM Petr Vorel <pvorel@suse.cz> wrote:
> Hi Andrea, Li,
>
> > Hi Andrea,
>
> ...
> > > +struct tst_results {
> > > + int num_pass;
> > > + int last_failed;
> > > +};
>
>
> > Well, I do not object to hiding the test outputting during
> > each run, but the disadvantage is if we deploy LTP in CI/CD
> > typically we get nothing useful on one-off failure logs.
> > (thus we have to rerun it with '-D' manually for reproduction)
>
> @Li For CI is more convenient to set LTP_ENABLE_DEBUG=1 environment
> variable.
> -D was meant for runtime testing when developing a test (faster than set
> an environment variable).
>
Oh, good to know this, thanks!
>
> I updated it in the docs (it was not mentioned there):
>
> https://linux-test-project.readthedocs.io/en/latest/developers/debugging.html
Nice.
>
> > So I can't tell if the total results are meaningful unless we get PASS
> > every run.
>
> > Or, we give more options in the runtest file for user choice?
>
> > # cat /runtest/syscalls
> > fcntl14_03 fcntl14 -n 10 -D
> > fcntl14_03_64 fcntl14_64 -n 10 -D
> > fcntl14_04 fcntl14 -n 10 -D -l
> > fcntl14_04_64 fcntl14_64 -n 10 -D -l
>
> > And, "tst_" prefix is only used by LTP common APIs, so here we shouldn't
> > abuse it.
>
> +1
>
After fixing the prefix name the patch looks good to me.
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-05-10 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 11:54 [LTP] [PATCH v2] Rewrite fcnt14 test Andrea Cervesato
2024-04-30 8:23 ` Li Wang
2024-05-09 10:20 ` Petr Vorel
2024-05-10 2:27 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEemH2cn5SwErswkQgsDFSP26DZtDMHnu_HAtKmFm5nV97eWOA@mail.gmail.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).