From: Geetika M <geetika@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] Hugetlb: Migrating libhugetlbfs test truncate_reserve_wraparound.c
Date: Wed, 27 Mar 2024 10:52:10 +0530 [thread overview]
Message-ID: <9e339bbd-0fda-4b44-bbcf-20c0303f494a@linux.ibm.com> (raw)
In-Reply-To: <20231128112511.GB364870@pevik>
On 28/11/23 4:55 pm, Petr Vorel wrote:
> Hi,
>
> Please have look at my comments at your colleague patch [1] [2], these changes
> apply a lot for your patches as well.
>
> [1] https://lore.kernel.org/ltp/20231128111024.GA364870@pevik/
> [2] https://lore.kernel.org/ltp/20231128112254.GA367506@pevik/
I will have a look at both of these and apply the changes that apply to
this
testcase and send the next version.
> ...
>> +++ b/runtest/hugetlb
>> @@ -35,6 +35,7 @@ hugemmap29 hugemmap29
>> hugemmap30 hugemmap30
>> hugemmap31 hugemmap31
>> hugemmap32 hugemmap32
>> +hugemmap38 hugemmap38
> nit: Why not hugemmap34? (your colleague used hugemmap33 for his patch [1].
We already have:
hugemmap34 :
https://lore.kernel.org/ltp/20230913082214.8453-1-samir@linux.vnet.ibm.com/
hugemmap36 :
https://lore.kernel.org/ltp/20230912064126.3350-1-samir@linux.vnet.ibm.com/
hugemmap35 :
https://lore.kernel.org/all/20230908121135.245296-1-sachinpb@linux.vnet.ibm.com/
hugemmap37 :
https://lore.kernel.org/ltp/20230929075435.72172-1-geetika@linux.ibm.com/
Hence hugemmap38!
>> hugemmap05_1 hugemmap05 -m
>> hugemmap05_2 hugemmap05 -s
>> hugemmap05_3 hugemmap05 -s -m
> ...
>
> Kind regards,
> Petr
Thanks & Regards,
Geetika
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-03-27 5:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 7:46 [LTP] [PATCH] Hugetlb: Migrating libhugetlbfs test truncate_reserve_wraparound.c Geetika
2023-11-28 11:25 ` Petr Vorel
2024-03-27 5:22 ` Geetika M [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e339bbd-0fda-4b44-bbcf-20c0303f494a@linux.ibm.com \
--to=geetika@linux.ibm.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).