From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] tcindex01: Pass if the tcindex module is blacklisted
Date: Wed, 15 May 2024 15:03:55 +0200 [thread overview]
Message-ID: <20240515130355.GA222948@pevik> (raw)
In-Reply-To: <ZkSUG0EtSyu6GvvW@yuki>
> Hi!
> > > diff --git a/testcases/cve/tcindex01.c b/testcases/cve/tcindex01.c
> > > index 70e5639f1..07239f9c0 100644
> > > --- a/testcases/cve/tcindex01.c
> > > +++ b/testcases/cve/tcindex01.c
> > > @@ -106,8 +106,19 @@ static void run(void)
> > > NETDEV_ADD_QDISC(DEVNAME, AF_UNSPEC, TC_H_ROOT, qd_handle, "htb",
> > > qd_config);
> > > NETDEV_ADD_TRAFFIC_CLASS(DEVNAME, qd_handle, clsid, "htb", cls_config);
> > > - NETDEV_ADD_TRAFFIC_FILTER(DEVNAME, qd_handle, 10, ETH_P_IP, 1,
> > > - "tcindex", f_config);
> > > + ret = tst_netdev_add_traffic_filter(__FILE__, __LINE__, 0, DEVNAME,
> I do not like that much that we add the __FILE__ and __LINE__ into the
> test by hand. Maybe just add another macro
> NETDEV_ADD_TRAFIC_FILTER_RET() so that we don't have to write these into
> the testcases?
IMHO it makes sense.
> > nit: we now don't use NETDEV_ADD_TRAFFIC_FILTER() macro any more. I guess it can
> > stay because you sooner or later will use it.
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > > + qd_handle, 10, ETH_P_IP, 1, "tcindex", f_config);
> > > + TST_ERR = tst_netlink_errno;
> > Out of curriosity, I suppose you save tst_netlink_errno to TST_ERR because it
> > would be overwritten later in other LTP netlink API functions.
> Because he wants to print it with TTERRNO later.
+1
> > > +
> > > + if (!ret && TST_ERR == ENOENT) {
> > > + tst_res(TPASS | TTERRNO,
> > > + "tcindex module is blacklisted or unavailable");
Why not TCONF? We are testing if removing tcindex does not cause bug,
right?
> > > + return;
> > > + }
> I guess that our .needs_drivers does not take blacklists into account,
> otherwise we could have just added tcindex into .needs_drivers.
Yes, it only searches modules.builtin and modules.dep.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-15 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 9:47 [LTP] [PATCH] tcindex01: Pass if the tcindex module is blacklisted Martin Doucha
2024-05-15 10:15 ` Petr Vorel
2024-05-15 10:53 ` Cyril Hrubis
2024-05-15 12:22 ` Petr Vorel
2024-05-15 12:34 ` Martin Doucha
2024-05-15 13:09 ` Petr Vorel
2024-05-15 13:03 ` Petr Vorel [this message]
2024-05-15 13:38 ` Martin Doucha
2024-05-15 13:46 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515130355.GA222948@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).