From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/3] runtest: Move capability related tests to new capability
Date: Thu, 9 May 2024 12:33:44 +0200 [thread overview]
Message-ID: <20240509103344.GD243374@pevik> (raw)
In-Reply-To: <ZjyaoluhhQrHW7xP@yuki>
Hi Cyril,
> Hi!
> > Move cap_bounds content to syscalls
> > runtest/cap_bounds and runtest/filecaps had both only single entry.
> > That's a waste of starting SUT, therefore create new runtest file
> > capability and move it there. Add there also runtest/securebits.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> > ---
> > Maybe it'd be safer to verify if the tests are still relevant now.
> > Because name is more promising than the actual content :).
> > Also we have other tests which use libcap.
> > Alternatively, we could just move them to syscalls.
> I would just merge them for now, since it's better than having one or
> two tests per file.
Right, merged this and 2nd patch. Thanks for your review!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-09 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 7:35 [LTP] [PATCH 0/3] runtest cleanup Petr Vorel
2024-01-30 7:35 ` [LTP] [PATCH 1/3] runtest: Move capability related tests to new capability Petr Vorel
2024-05-09 9:42 ` Cyril Hrubis
2024-05-09 10:33 ` Petr Vorel [this message]
2024-01-30 7:35 ` [LTP] [PATCH 2/3] runtest: Move io content to ltp-aiodio.part4 Petr Vorel
2024-05-09 9:45 ` Cyril Hrubis
2024-01-30 7:35 ` [LTP] [PATCH 3/3] runtest: Remove 'ltp-' prefix from aio* runtests Petr Vorel
2024-05-09 9:46 ` Cyril Hrubis
2024-05-09 10:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509103344.GD243374@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).