From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>,
Kent Overstreet <kent.overstreet@linux.dev>,
Brian Foster <bfoster@redhat.com>,
fstests@vger.kernel.org, linux-bcachefs@vger.kernel.org,
Richard Palethorpe <rpalethorpe@suse.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] lib: Add support bcachefs filesystem
Date: Tue, 7 May 2024 19:10:11 +0200 [thread overview]
Message-ID: <20240507171011.GD157588@pevik> (raw)
In-Reply-To: <20231207175538.GA248849@pevik>
Hi all,
> > Hi!
> > > bcachefs has been merged into v6.7-rc1 [1]. Let's add it's support to
> > > LTP .all_filesystems = 1 and TST_ALL_FILESYSTEMS=1.
> > > [1] https://lwn.net/Articles/934692/
> > > Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > > ---
> > > Hi,
> > > this should be merged after v6.7 is released.
> > Agreed, although it's unlikey that they will pull bcachefs off from the
> > tree now. Any way I think that we should add the support to the next
> > release.
> Yep, now it's 6.7-rc4. I'll prepare v2
> > > So far I haven't tested all LTP tests on bcachefs temporary directory.
> > > I have only tested tests which use .all_filesystems = 1 or TST_ALL_FILESYSTEMS=1.
> > > So far it looks like there are only a few tests failing:
> > > statvfs01.c:44: TFAIL: creat(valid_fname, 0444) failed: ENAMETOOLONG (36)
> > That strange, that would mean that statvfs() reports possibly wrong
> > f_namemax. Looking at the code the f_namemax is initialized to
> > BCH_NAME_MAX in bch2_statfs().
> > And the dirent_create_key() does:
> > if (name->len > BCH_NAME_MAX)
> > return ERR_PTR(-ENAMETOOLONG);
> > That does not look like there is any room for a failure. Maybe we can
> > print the buf.f_namemax value in the test and check if it's 512 since
> > that is the value of BCH_NAME_MAX.
FYI Unfortunately ENAMETOOLONG is still problem on statvfs() on bcachefs.
Kind regards,
Petr
...
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-07 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 13:55 [LTP] [PATCH 1/1] lib: Add support bcachefs filesystem Petr Vorel
2023-12-07 14:33 ` Cyril Hrubis
2023-12-07 17:55 ` Petr Vorel
2024-05-07 17:10 ` Petr Vorel [this message]
2023-12-07 19:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507171011.GD157588@pevik \
--to=pvorel@suse.cz \
--cc=bfoster@redhat.com \
--cc=chrubis@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).