From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v7] clone3: Add clone3's clone_args cgroup
Date: Thu, 4 Apr 2024 22:42:58 +0200 [thread overview]
Message-ID: <20240404204258.GA565448@pevik> (raw)
In-Reply-To: <20230831064727.5790-1-wegao@suse.com>
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> include/lapi/sched.h | 8 ++
> include/tst_cgroup.h | 4 +
> include/tst_clone.h | 1 +
> lib/tst_cgroup.c | 8 ++
> lib/tst_clone.c | 1 +
> runtest/syscalls | 1 +
> testcases/kernel/syscalls/clone3/.gitignore | 1 +
> testcases/kernel/syscalls/clone3/clone303.c | 95 +++++++++++++++++++++
Note lib changes should have been separated from adding new test clone303.c
(commit would be readable).
> 8 files changed, 119 insertions(+)
> create mode 100644 testcases/kernel/syscalls/clone3/clone303.c
> diff --git a/include/lapi/sched.h b/include/lapi/sched.h
> index 1065665d1..ac766efc5 100644
> --- a/include/lapi/sched.h
> +++ b/include/lapi/sched.h
> @@ -13,6 +13,7 @@
> #include <inttypes.h>
> #include "config.h"
> #include "lapi/syscalls.h"
> +#include "lapi/sched.h"
> struct sched_attr {
> uint32_t size;
> @@ -54,6 +55,9 @@ struct clone_args {
> uint64_t __attribute__((aligned(8))) stack;
> uint64_t __attribute__((aligned(8))) stack_size;
> uint64_t __attribute__((aligned(8))) tls;
> + uint64_t __attribute__((aligned(8))) set_tid;
> + uint64_t __attribute__((aligned(8))) set_tid_size;
> + uint64_t __attribute__((aligned(8))) cgroup;
Adding new members introduced warnings like this:
tst_ns_exec.c: In function ‘main’:
tst_ns_exec.c:70:16: warning: missing initializer for field ‘cgroup’ of ‘struct tst_clone_args’ [-Wmissing-field-initializers]
70 | struct tst_clone_args args = { 0, SIGCHLD };
| ^~~~~~~~~~~~~~
In file included from ../../include/tst_test.h:113,
from tst_ns_exec.c:20:
../../include/tst_clone.h:14:18: note: ‘cgroup’ declared here
14 | uint64_t cgroup;
| ^~~~~~
I'm going to fix it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-04-04 20:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 0:35 [LTP] [PATCH v1] clone3: Add clone3's clone_args cgroup Wei Gao via ltp
2023-03-23 9:26 ` Petr Vorel
2023-03-23 12:17 ` Wei Gao via ltp
2023-03-24 6:32 ` Petr Vorel
2023-03-24 6:54 ` Wei Gao via ltp
2023-03-24 8:26 ` Petr Vorel
2023-04-21 12:38 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-04-21 13:29 ` Cyril Hrubis
2023-04-22 1:42 ` [LTP] [PATCH v3] " Wei Gao via ltp
2023-04-26 13:44 ` Cyril Hrubis
2023-05-09 0:31 ` [LTP] [PATCH v4] " Wei Gao via ltp
2023-05-17 9:28 ` Petr Vorel
2023-05-17 12:08 ` [LTP] [PATCH v5] " Wei Gao via ltp
2023-08-25 10:36 ` Richard Palethorpe
2023-08-29 23:26 ` Wei Gao via ltp
2023-08-30 8:02 ` Richard Palethorpe
2023-08-29 23:18 ` [LTP] [PATCH v6] " Wei Gao via ltp
2023-08-31 6:47 ` [LTP] [PATCH v7] " Wei Gao via ltp
2023-08-31 9:19 ` Richard Palethorpe
2023-09-01 10:19 ` Petr Vorel
2023-09-01 10:22 ` Petr Vorel
2023-09-02 5:05 ` Wei Gao via ltp
2024-04-04 20:42 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404204258.GA565448@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).