From: "Bang Li" <libang.li@antgroup.com>
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, chenhuacai@kernel.org,
tsbogend@alpha.franken.de, paul.walmsley@sifive.com,
palmer@dabbelt.com, chris@zankel.net, jcmvbkbc@gmail.com,
david@redhat.com, ryan.roberts@arm.com, libang.linux@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v1 5/5] mm: Add update_mmu_tlb_range()
Date: Sun, 05 May 2024 22:29:59 +0800 [thread overview]
Message-ID: <f3114a5a-3ddb-474b-897c-0d96d25c31f9@antgroup.com> (raw)
In-Reply-To: <CAK1f24n4usJm4=e0+jrTxGtRjqTJZvn4gBp8d_vU=p2CrU=TsA@mail.gmail.com>
Hey Lance,
Thanks for taking time to review!
On 2024/4/29 19:23, Lance Yang wrote:
> Hey Bang,
>
> On Mon, Apr 29, 2024 at 6:36 PM Bang Li <libang.li@antgroup.com> wrote:
>>
>> After the commit 19eaf44954df ("mm: thp: support allocation of anonymous
>> multi-size THP"), it may need to batch update tlb of an address range
>> through the update_mmu_tlb function. We can simplify this operation by
>> adding the update_mmu_tlb_range function, which may also reduce the
>> execution of some unnecessary code in some architectures.
>>
>> Signed-off-by: Bang Li <libang.li@antgroup.com>
>> ---
>> include/linux/pgtable.h | 5 +++++
>> mm/memory.c | 4 +---
>> 2 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
>> index 18019f037bae..73411dfebf7a 100644
>> --- a/include/linux/pgtable.h
>> +++ b/include/linux/pgtable.h
>> @@ -734,6 +734,11 @@ static inline void update_mmu_tlb(struct vm_area_struct *vma,
>> unsigned long address, pte_t *ptep)
>> {
>> }
>> +
>> +static inline void update_mmu_tlb_range(struct vm_area_struct *vma,
>> + unsigned long address, pte_t *ptep, unsigned int nr)
>> +{
>> +}
>> #define __HAVE_ARCH_UPDATE_MMU_TLB
>> #endif
>
> IMO, it might be better to use a separate definition to determine whether
> update_mmu_tlb_range() is overridden by a specific architecture.
I have also considered this, and I will modify it in the next version.
thank you again for your review!
Thanks,
Bang
>
> Thanks,
> Lance
>
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index 6647685fd3c4..1f0ca362b82a 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -4396,7 +4396,6 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>> vm_fault_t ret = 0;
>> int nr_pages = 1;
>> pte_t entry;
>> - int i;
>>
>> /* File mapping without ->vm_ops ? */
>> if (vma->vm_flags & VM_SHARED)
>> @@ -4465,8 +4464,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>> update_mmu_tlb(vma, addr, vmf->pte);
>> goto release;
>> } else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) {
>> - for (i = 0; i < nr_pages; i++)
>> - update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i);
>> + update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages);
>> goto release;
>> }
>>
>> --
>> 2.19.1.6.gb485710b
>>
prev parent reply other threads:[~2024-05-05 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 10:33 [PATCH v1 0/5] Add update_mmu_tlb_range() to simplify code Bang Li
2024-04-29 10:33 ` [PATCH v1 1/5] LoongArch: Add update_mmu_tlb_range() Bang Li
2024-04-29 10:33 ` [PATCH v1 2/5] mips: " Bang Li
2024-04-29 10:33 ` [PATCH v1 3/5] riscv: " Bang Li
2024-04-29 10:33 ` [PATCH v1 4/5] xtensa: " Bang Li
2024-04-29 10:33 ` [PATCH v1 5/5] mm: " Bang Li
2024-04-29 11:23 ` Lance Yang
2024-05-05 14:29 ` Bang Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3114a5a-3ddb-474b-897c-0d96d25c31f9@antgroup.com \
--to=libang.li@antgroup.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=david@redhat.com \
--cc=ioworker0@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=libang.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ryan.roberts@arm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).