From: Tianyang Zhang <zhangtianyang@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>,
chenhuacai@kernel.org, kernel@xen0n.name, tglx@linutronix.de,
jiaxun.yang@flygoat.com, gaoliang@loongson.cn,
wangliupu@loongson.cn, lvjianmin@loongson.cn, yijun@loongson.cn,
mhocko@suse.com, akpm@linux-foundation.org,
dianders@chromium.org, maobibo@loongson.cn,
zhaotianrui@loongson.cn, nathan@kernel.org,
yangtiezhu@loongson.cn, zhoubinbin@loongson.cn
Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Loongarch:Support loongarch avec
Date: Mon, 13 May 2024 14:41:45 +0800 [thread overview]
Message-ID: <b38caf8e-b817-7ea2-50e3-eef78909b642@loongson.cn> (raw)
In-Reply-To: <a0a896fef1aca8958a190801ab5355e22373081d.camel@xry111.site>
在 2024/5/7 下午10:20, Xi Ruoyao 写道:
> On Tue, 2024-05-07 at 20:59 +0800, Tianyang Zhang wrote:
>> +static inline void loongarch_avec_ack_irq(struct irq_data *d)
>> +{
>> +}
>> +
>> +static inline void loongarch_avec_unmask_irq(struct irq_data *d)
>> +{
>> +}
>> +
>> +static inline void loongarch_avec_mask_irq(struct irq_data *d)
>> +{
>> +}
> "inline" has no use here because these functions are only called via
> function pointers, thus such calls cannot be inline-able. I'd suggest
> to remove "inline" for them.
>
Thank you for your feedback. I will make the necessary changes here
next prev parent reply other threads:[~2024-05-13 6:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 12:59 [PATCH 2/2] Loongarch:Support loongarch avec Tianyang Zhang
2024-05-07 14:20 ` Xi Ruoyao
2024-05-13 6:41 ` Tianyang Zhang [this message]
2024-05-08 6:19 ` kernel test robot
2024-05-08 7:00 ` maobibo
2024-05-13 6:53 ` Tianyang Zhang
2024-05-08 9:43 ` Thomas Gleixner
2024-05-14 2:39 ` Tianyang Zhang
2024-05-08 21:18 ` kernel test robot
2024-05-08 21:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38caf8e-b817-7ea2-50e3-eef78909b642@loongson.cn \
--to=zhangtianyang@loongson.cn \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@kernel.org \
--cc=dianders@chromium.org \
--cc=gaoliang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=mhocko@suse.com \
--cc=nathan@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangliupu@loongson.cn \
--cc=xry111@xry111.site \
--cc=yangtiezhu@loongson.cn \
--cc=yijun@loongson.cn \
--cc=zhaotianrui@loongson.cn \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).