From: Huacai Chen <chenhuacai@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH] LoongArch: addrspace: add linux/sizes.h to prevent build errors
Date: Fri, 5 Apr 2024 17:23:09 +0800 [thread overview]
Message-ID: <CAAhV-H5FOWKCB7kXQ4KT2cOc=MwucnQeK3+vPtv+QgwCQmc2sA@mail.gmail.com> (raw)
In-Reply-To: <20240404045701.27284-1-rdunlap@infradead.org>
Queued, thanks.
Huacai
On Thu, Apr 4, 2024 at 12:57 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> LoongArch's include/asm/addrspace.h uses SZ_32M and SZ_16K, so add
> <linux/sizes.h> to provide those macros to prevent build errors:
>
> In file included from ../arch/loongarch/include/asm/io.h:11,
> from ../include/linux/io.h:13,
> from ../include/linux/io-64-nonatomic-lo-hi.h:5,
> from ../drivers/cxl/pci.c:4:
> ../include/asm-generic/io.h: In function 'ioport_map':
> ../arch/loongarch/include/asm/addrspace.h:124:25: error: 'SZ_32M' undeclared (first use in this function); did you mean 'PS_32M'?
> 124 | #define PCI_IOSIZE SZ_32M
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: loongarch@lists.linux.dev
> ---
> arch/loongarch/include/asm/addrspace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/loongarch/include/asm/addrspace.h b/arch/loongarch/include/asm/addrspace.h
> --- a/arch/loongarch/include/asm/addrspace.h
> +++ b/arch/loongarch/include/asm/addrspace.h
> @@ -11,6 +11,7 @@
> #define _ASM_ADDRSPACE_H
>
> #include <linux/const.h>
> +#include <linux/sizes.h>
>
> #include <asm/loongarch.h>
>
prev parent reply other threads:[~2024-04-05 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 4:57 [PATCH] LoongArch: addrspace: add linux/sizes.h to prevent build errors Randy Dunlap
2024-04-05 9:23 ` Huacai Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H5FOWKCB7kXQ4KT2cOc=MwucnQeK3+vPtv+QgwCQmc2sA@mail.gmail.com' \
--to=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).