From: Huacai Chen <chenhuacai@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: kernel test robot <lkp@intel.com>,
WANG Xuerui <kernel@xen0n.name>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Nathan Chancellor <nathan@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Fangrui Song <maskray@google.com>,
loongarch@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
Qing Zhang <zhangqing@loongson.cn>,
Feiyang Chen <chenfeiyang@loongson.cn>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] LoongArch: vDSO: Disable UBSAN instrumentation
Date: Wed, 31 Jan 2024 14:05:34 +0800 [thread overview]
Message-ID: <CAAhV-H524mSc5SgiwVF3aATFkrp0_xo2W7-5sXk0nXyN+rBzrA@mail.gmail.com> (raw)
In-Reply-To: <20240130233140.work.887-kees@kernel.org>
Queued, thanks.
Huacai
On Wed, Jan 31, 2024 at 7:31 AM Kees Cook <keescook@chromium.org> wrote:
>
> The vDSO executes in userspace, so the kernel's UBSAN should not
> instrument it. Solves these kind of build errors:
>
> loongarch64-linux-ld: arch/loongarch/vdso/vgettimeofday.o: in function `vdso_shift_ns':
> lib/vdso/gettimeofday.c:23:(.text+0x3f8): undefined reference to `__ubsan_handle_shift_out_of_bounds'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401310530.lZHCj1Zl-lkp@intel.com/
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Fangrui Song <maskray@google.com>
> Cc: loongarch@lists.linux.dev
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> arch/loongarch/vdso/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index c74c9921304f..f597cd08a96b 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -2,6 +2,7 @@
> # Objects to go into the VDSO.
>
> KASAN_SANITIZE := n
> +UBSAN_SANITIZE := n
> KCOV_INSTRUMENT := n
>
> # Include the generic Makefile to check the built vdso.
> --
> 2.34.1
>
prev parent reply other threads:[~2024-01-31 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 23:31 [PATCH] LoongArch: vDSO: Disable UBSAN instrumentation Kees Cook
2024-01-31 6:05 ` Huacai Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhV-H524mSc5SgiwVF3aATFkrp0_xo2W7-5sXk0nXyN+rBzrA@mail.gmail.com \
--to=chenhuacai@kernel.org \
--cc=chenfeiyang@loongson.cn \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=maskray@google.com \
--cc=nathan@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).