From: Guenter Roeck <linux@roeck-us.net>
To: Huacai Chen <chenhuacai@kernel.org>, Marco Elver <elver@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dmitry Vyukov <dvyukov@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
loongarch@lists.linux.dev
Subject: Re: hw_breakpoint unit test failures with various architectures/platforms in qemu
Date: Tue, 5 Mar 2024 06:20:48 -0800 [thread overview]
Message-ID: <9e0a8efd-9af8-49eb-a9b9-950ee582921b@roeck-us.net> (raw)
In-Reply-To: <CAAhV-H4KoFLM1Kf-42CuWbkvRuHOJkBzkudWUNpAY0KMUBqUkA@mail.gmail.com>
On 3/5/24 01:05, Huacai Chen wrote:
> Hi, Marco,
>
> On Tue, Mar 5, 2024 at 4:34 AM Marco Elver <elver@google.com> wrote:
>>
>> On Mon, 4 Mar 2024 at 19:12, Guenter Roeck <linux@roeck-us.net> wrote:
>>>
>>> Hi,
>>>
>>> I see a number of failures and tracebacks when running the hw_breakpoint
>>> unit tests on various architectures in qemu. Some examples are below.
>>>
>>> Is this a potential problem with the unit tests, with the hardware,
>>> or with the qemu emulation of that hardware ?
>>
>> The test is testing the accounting logic (allocating/deallocating HW
>> breakpoints), not actually using the breakpoints. That requires that
>> the architecture reports the correct number of HW breakpoints
>> available. It looks like it's not doing that.
>>
>>> In other words, is it worthwhile to look into this further, or would
>>> it make more sense to just disable those tests if they fail on a
>>> given hardware/platform ?
>>
>> It's an arch bug:
>> https://lore.kernel.org/lkml/Ytl9L0Zn1PVuL1cB@FVFF77S0Q05N.cambridge.arm.com/
>>
>> Back then we decided to leave the test as-is, given it's reporting an
>> actual issue. However, since then nothing has changed and the test
>> continues to exist as a reminder the arch code needs fixing. I suspect
>> none of us have the time to get to that soon, so we can either leave
>> things as is, or skip the test on all the broken architectures.
>>
>> No idea what's going on with loongarch.
> LoongArch's problem comes from QEMU, I have tested on real machine.
>
> [ 7.222500] KTAP version 1
> [ 7.226067] 1..1
> [ 7.228795] KTAP version 1
> [ 7.232737] # Subtest: hw_breakpoint
> [ 7.237512] # module: hw_breakpoint_test
> [ 7.237520] 1..9
> [ 7.442899] ok 1 test_one_cpu
> [ 7.443912] ok 2 test_many_cpus
> [ 7.451298] ok 3 test_one_task_on_all_cpus
> [ 7.456486] ok 4 test_two_tasks_on_all_cpus
> [ 7.462291] ok 5 test_one_task_on_one_cpu
> [ 7.468293] ok 6 test_one_task_mixed
> [ 7.474405] ok 7 test_two_tasks_on_one_cpu
> [ 7.479884] ok 8 test_two_tasks_on_one_all_cpus
> [ 7.485699] ok 9 test_task_on_all_and_one_cpu
> [ 7.491488] # hw_breakpoint: pass:9 fail:0 skip:0 total:9
> [ 7.496985] # Totals: pass:9 fail:0 skip:0 total:9
> [ 7.503179] ok 1 hw_breakpoint
>
> Huacai
>
That is good to know. Thanks a lot for testing!
Guenter
prev parent reply other threads:[~2024-03-05 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f477329e-4ecf-4c6c-82b1-1e9b84443902@roeck-us.net>
2024-03-04 20:34 ` hw_breakpoint unit test failures with various architectures/platforms in qemu Marco Elver
2024-03-04 21:17 ` Guenter Roeck
2024-03-05 9:05 ` Huacai Chen
2024-03-05 14:20 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e0a8efd-9af8-49eb-a9b9-950ee582921b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).