From: peterx@redhat.com
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Huacai Chen <chenhuacai@kernel.org>,
peterx@redhat.com, David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Nathan Chancellor <nathan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
WANG Xuerui <kernel@xen0n.name>,
Ryan Roberts <ryan.roberts@arm.com>,
loongarch@lists.linux.dev
Subject: [PATCH 0/3] mm/gup: fixups for hugetlb gup rework series
Date: Tue, 2 Apr 2024 21:32:46 -0400 [thread overview]
Message-ID: <20240403013249.1418299-1-peterx@redhat.com> (raw)
From: Peter Xu <peterx@redhat.com>
Hi,
This is a small patchset that will fix two known issues that got reported
today on the previous hugetlb unification series on slow gup [1].
The first issue was reported by Ryan Roberts [2] on a test failure over
gup_longterm. Patch 1-2 should fix it. Tested with 32MB hugepages on
arm64 VM.
The second issue was reported by Nathan Chancellor [3] on a build issue
over loongson's defconfig (loongson3_defconfig). It can be easily
reproduced with my own build setup [4], while patch 3 fixes it, and should
hopefully fix similar archs where pud_pfn() is not defined even if
pud_leaf() can return true.
For the 2nd issue, it's debatable whether it's an arch issue, because
logically speaking pud_pfn() and pud_leaf() should either be both defined
or both not. But since the current fix will be the simplest and still safe
(I at least checked loongarch doesn't support either pud dax or pud
hugetlb), I think we can consider having this to unbreak the build first,
assuming this could also happen to other archs.
One note is that the last 2 patches should be squashed into corresponding
patch, while the 1st patch should be kept standalone.
Thanks,
[1] https://lore.kernel.org/r/20240327152332.950956-1-peterx@redhat.com
[2] https://lore.kernel.org/r/adfdd89b-ee56-4758-836e-c66a0be7de25@arm.com
[3] https://lore.kernel.org/r/ZgyKLLVZ4vN56uZE@x1n
[4] https://gitlab.com/peterx/lkb-harness/-/blob/main/config.json?ref_type=heads#L32
Peter Xu (3):
mm: Allow anon exclusive check over hugetlb tail pages
fixup! mm/gup: handle huge pmd for follow_pmd_mask()
fixup! mm/arch: provide pud_pfn() fallback
include/linux/page-flags.h | 8 +++++++-
include/linux/pgtable.h | 6 +++++-
mm/gup.c | 3 ---
mm/internal.h | 10 ----------
4 files changed, 12 insertions(+), 15 deletions(-)
--
2.44.0
next reply other threads:[~2024-04-03 1:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 1:32 peterx [this message]
2024-04-03 1:32 ` [PATCH 1/3] mm: Allow anon exclusive check over hugetlb tail pages peterx
2024-04-03 7:37 ` David Hildenbrand
2024-04-04 0:05 ` Matthew Wilcox
2024-04-04 13:45 ` Peter Xu
2024-04-04 14:06 ` Matthew Wilcox
2024-04-04 14:21 ` Peter Xu
2024-04-04 20:31 ` Andrew Morton
2024-04-04 20:36 ` Peter Xu
2024-04-03 1:32 ` [PATCH 2/3] fixup! mm/gup: handle huge pmd for follow_pmd_mask() peterx
2024-04-03 1:32 ` [PATCH 3/3] fixup! mm/arch: provide pud_pfn() fallback peterx
2024-04-03 11:06 ` [PATCH 0/3] mm/gup: fixups for hugetlb gup rework series Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403013249.1418299-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@kernel.org \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=loongarch@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).