From: WangYuli <wangyuli@uniontech.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
chenhuacai@kernel.org, kernel@xen0n.name
Cc: linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, WangYuli <wangyuli@uniontech.com>,
Guan Wentao <guanwentao@uniontech.com>
Subject: [PATCH] loongarch/crypto: Clean up useless assignment operations
Date: Mon, 26 Feb 2024 16:03:28 +0800 [thread overview]
Message-ID: <20240226080328.334021-1-wangyuli@uniontech.com> (raw)
Both crc32 and crc32c hw accelerated funcs will calculate the
remaining len. Those codes are derived from
arch/mips/crypto/crc32-mips.c and "len -= sizeof(u32)" is not
necessary for 64-bit CPUs.
Removing it can make context code style more unified and improve
code readability.
Suggested-by: Guan Wentao <guanwentao@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
arch/loongarch/crypto/crc32-loongarch.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/crypto/crc32-loongarch.c
index a49e507af38c..3eebea3a7b47 100644
--- a/arch/loongarch/crypto/crc32-loongarch.c
+++ b/arch/loongarch/crypto/crc32-loongarch.c
@@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
CRC32(crc, value, w);
p += sizeof(u32);
- len -= sizeof(u32);
}
if (len & sizeof(u16)) {
@@ -80,7 +79,6 @@ static u32 crc32c_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
CRC32C(crc, value, w);
p += sizeof(u32);
- len -= sizeof(u32);
}
if (len & sizeof(u16)) {
--
2.33.1
next reply other threads:[~2024-02-26 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 8:03 WangYuli [this message]
2024-02-26 8:15 ` [PATCH] loongarch/crypto: Clean up useless assignment operations WANG Xuerui
2024-02-26 8:25 ` 关文涛
2024-02-27 7:42 ` WANG Xuerui
2024-02-27 9:22 ` Xi Ruoyao
2024-02-27 7:52 ` WANG Xuerui
2024-02-27 8:44 ` 关文涛
2024-02-27 9:14 ` 王昱力
2024-02-29 3:05 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226080328.334021-1-wangyuli@uniontech.com \
--to=wangyuli@uniontech.com \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=guanwentao@uniontech.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@xen0n.name \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).