From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] Support for Enermax DigiFanless 550W PSU
Date: Mon, 17 Aug 2015 06:11:18 +0000 [thread overview]
Message-ID: <55D17B06.60108@roeck-us.net> (raw)
In-Reply-To: <CAF=9fWv3JY_ejXwa9Z93YYnbEOXQjgt-xh60nT4GySwMY7b-yA@mail.gmail.com>
On 08/16/2015 08:57 PM, Frank Schaefer wrote:
> Regarding the placement of the driver, I'm actually kind of torn on
> this myself. Mainly because the driver includes hid-ids.h, which for
> some reason resides in drivers/hid instead of the more logical
> include/linux. I could obviously move things around and still include
> it as "../hid/hid-ids.h", although that feels wrong as well.
>
> I can do whichever you feel is the lesser of two evils; in the
> meantime, I'll focus on cleaning up and re-testing the code.
>
That depends on the hid maintainers, really. If an include file from the
hid directory is needed, the driver should either reside there or the code
should be reworked to not require it.
Main problem I have with drivers outside their subsystem is that they
are often not properly maintained, and they are often not reviewed by people
who know the subsystem. That you copied lm-sensors with your patch is really
the exception; most of the time that doesn't happen, and very often such
drivers have problems or don't even work in the first place.
But, again, that really depends on the hid maintainers. If the common hid
approach is to have all hid drivers there, so be it.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2015-08-17 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 22:56 [lm-sensors] [PATCH] Support for Enermax DigiFanless 550W PSU Frank Schaefer
2015-08-17 1:13 ` Guenter Roeck
2015-08-17 3:57 ` Frank Schaefer
2015-08-17 6:11 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D17B06.60108@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).