From: Rob Herring <robh@kernel.org>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: lm-sensors@lm-sensors.org, devicetree@vger.kernel.org,
linux@roeck-us.net, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3] hwmon/max6650.c: Add devicetree support
Date: Fri, 12 Aug 2016 18:26:21 +0000 [thread overview]
Message-ID: <20160812182621.GA30513@rob-hp-laptop> (raw)
In-Reply-To: <1470838787-8273-1-git-send-email-mike.looijmans@topic.nl>
On Wed, Aug 10, 2016 at 04:19:47PM +0200, Mike Looijmans wrote:
> Parse devicetree parameters for voltage and prescaler setting. This allows
> using multiple max6550 devices with varying settings, and also makes it
> possible to instantiate and configure the device using devicetree.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> v3: Resubmit because mailing lists bounced
> Fix style errors as reported by checkpatch.pl
> Fix bug in DT parsing of fan-prescale
> v2: Add devicetree binding documentation
> Code changes as suggested by Guenter
> Reduce log info, output only a single line
>
> .../devicetree/bindings/hwmon/max6650.txt | 20 ++++++++++++++++
> drivers/hwmon/max6650.c | 28 +++++++++++++---------
> 2 files changed, 37 insertions(+), 11 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hwmon/max6650.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/max6650.txt b/Documentation/devicetree/bindings/hwmon/max6650.txt
> new file mode 100644
> index 0000000..89d87c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/max6650.txt
> @@ -0,0 +1,20 @@
> +Bindings for MAX6651 and MAX6650 I2C fan controllers
> +
> +Required properties:
> +- compatible : One of "max6650" or "max6651"
Needs a vendor prefix.
> +- reg : I2C address
> +
> +Optional properties:
> +- fan-voltage : The supply voltage of the fan. Valid values are 5 and 12.
This is in volts? Please use microvolt and the standard unit suffix as
found in property-units.txt.
> + Default is to use the chip's current setting.
> +- fan-prescale : Pre-scaling value as per datasheet. Valid are 1, 2, 4, 8, 16.
> + Default is to use the chip's current setting.
Add a vendor prefix here.
> +
> +
> +Example:
> + fan-max6650: max6650@1b {
> + reg = <0x1b>;
> + compatible = "max6650";
> + fan-voltage = <12>;
> + fan-prescale = <4>;
> + };
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2016-08-12 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 7:30 [lm-sensors] [RFC][PATCH] hwmon/max6650.c: Optionally retrieve voltage and prescaler from devicetree Mike Looijmans
2016-08-09 7:52 ` [lm-sensors] [RFC][PATCH] hwmon/max6650.c: Optionally retrieve voltage and prescaler from device Mike Looijmans
2016-08-09 16:37 ` Guenter Roeck
2016-08-10 7:46 ` [lm-sensors] [PATCH v2] hwmon/max6650.c: Add devicetree support Mike Looijmans
2016-08-10 14:19 ` [lm-sensors] [PATCH v3] " Mike Looijmans
2016-08-11 14:43 ` Guenter Roeck
2016-08-12 18:26 ` Rob Herring [this message]
2016-08-10 7:06 ` [lm-sensors] [RFC][PATCH] hwmon/max6650.c: Optionally retrieve voltage and prescaler from device Mike Looijmans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812182621.GA30513@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).