From: Rob Herring <robh@kernel.org>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: linux@roeck-us.net, shawnguo@kernel.org, jdelvare@suse.com,
stefan@agner.ch, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v3 2/3] ARM: dts: Change iio_hwmon nodes to use hypen in node names
Date: Mon, 22 Feb 2016 02:53:37 +0000 [thread overview]
Message-ID: <20160222025337.GA15973@rob-hp-laptop> (raw)
In-Reply-To: <c47b13603fe72737ef67ed8b90fc61516cfa2a20.1455597464.git.maitysanchayan@gmail.com>
On Tue, Feb 16, 2016 at 10:30:54AM +0530, Sanchayan Maity wrote:
> Change iio_hwmon nodes to use hypen in node names instead of
> underscore.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> Documentation/devicetree/bindings/iio/iio-bindings.txt | 2 +-
> arch/arm/boot/dts/imx23.dtsi | 2 +-
> arch/arm/boot/dts/imx28.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
No real objection here though I don't think this is really necessary.
While we prefer '-' to '_' it's not really strong enough to change. It
bothers me more that the node name leaks to userspace.
Rob
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2016-02-22 2:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 5:12 [lm-sensors] [PATCH v3 0/3] Allow iio_hwmon to accept hypen in node names Sanchayan Maity
2016-02-16 5:12 ` [lm-sensors] [PATCH v3 1/3] hwmon: iio_hwmon: Allow the driver to accept hypen in device tree node n Sanchayan Maity
2016-02-16 5:12 ` [lm-sensors] [PATCH v3 2/3] ARM: dts: Change iio_hwmon nodes to use hypen in node names Sanchayan Maity
2016-02-22 2:53 ` Rob Herring [this message]
2016-02-16 5:12 ` [lm-sensors] [PATCH v3 3/3] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Sanchayan Maity
2016-02-16 17:50 ` Stefan Agner
2016-02-17 3:37 ` [lm-sensors] [PATCH v3 0/3] Allow iio_hwmon to accept hypen in node names Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222025337.GA15973@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=maitysanchayan@gmail.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).