From: Il Han <corone.il.han@gmail.com>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH 2/2] hwmon: The Code Crashes
Date: Wed, 26 Aug 2015 05:41:59 +0000 [thread overview]
Message-ID: <1440567719-27643-2-git-send-email-corone.il.han@gmail.com> (raw)
The code crashes, since dev is not an i2c client device.
Signed-off-by: Il Han <corone.il.han@gmail.com>
---
drivers/hwmon/max31790.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c
index d9b0003..f129668 100644
--- a/drivers/hwmon/max31790.c
+++ b/drivers/hwmon/max31790.c
@@ -206,8 +206,8 @@ static ssize_t set_fan_target(struct device *dev,
const char *buf, size_t count)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
- struct i2c_client *client = to_i2c_client(dev);
- struct max31790_data *data = i2c_get_clientdata(client);
+ struct max31790_data *data = dev_get_drvdata(dev);
+ struct i2c_client *client = data->client;
u8 bits;
int sr;
int target_count;
@@ -273,8 +273,8 @@ static ssize_t set_pwm(struct device *dev,
const char *buf, size_t count)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
- struct i2c_client *client = to_i2c_client(dev);
- struct max31790_data *data = i2c_get_clientdata(client);
+ struct max31790_data *data = dev_get_drvdata(dev);
+ struct i2c_client *client = data->client;
unsigned long pwm;
int err;
@@ -325,8 +325,8 @@ static ssize_t set_pwm_enable(struct device *dev,
const char *buf, size_t count)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
- struct i2c_client *client = to_i2c_client(dev);
- struct max31790_data *data = i2c_get_clientdata(client);
+ struct max31790_data *data = dev_get_drvdata(dev);
+ struct i2c_client *client = data->client;
unsigned long mode;
int err;
--
2.4.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2015-08-26 5:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 5:41 Il Han [this message]
2015-08-26 14:06 ` [lm-sensors] [PATCH 2/2] hwmon: The Code Crashes Guenter Roeck
2015-08-26 14:56 ` Il Han
2015-08-26 15:26 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440567719-27643-2-git-send-email-corone.il.han@gmail.com \
--to=corone.il.han@gmail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).