From: John Hubbard <jhubbard@nvidia.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
Shuah Khan <shuah@kernel.org>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Valentin Obst" <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v3] selftests/resctrl: fix clang build warnings related to abs(), labs() calls
Date: Wed, 8 May 2024 13:32:20 -0700 [thread overview]
Message-ID: <7aeeb366-e28a-4b6c-a9c4-dd16882fd1a1@nvidia.com> (raw)
In-Reply-To: <2f172ee0-1c9a-4637-b2fd-574acb9a69a7@intel.com>
On 5/8/24 1:24 PM, Reinette Chatre wrote:
> Hi John,
>
> On 5/8/2024 12:41 PM, John Hubbard wrote:
...
>> diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c
>> index 7946e32e85c8..5fffbc9ff6a4 100644
>> --- a/tools/testing/selftests/resctrl/mba_test.c
>> +++ b/tools/testing/selftests/resctrl/mba_test.c
>> @@ -60,7 +60,7 @@ static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc)
>> /* Memory bandwidth from 100% down to 10% */
>> for (allocation = 0; allocation < ALLOCATION_MAX / ALLOCATION_STEP;
>> allocation++) {
>> - unsigned long avg_bw_imc, avg_bw_resc;
>> + long avg_bw_imc, avg_bw_resc;
>> unsigned long sum_bw_imc = 0, sum_bw_resc = 0;
>
> nit: since you are touching this line, could you please move it down one line to
> establish reverse fir order?
>
>> int avg_diff_per;
>> float avg_diff;
>> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
>> index d67ffa3ec63a..a4c3ea49b0e8 100644
>> --- a/tools/testing/selftests/resctrl/mbm_test.c
>> +++ b/tools/testing/selftests/resctrl/mbm_test.c
>> @@ -17,7 +17,7 @@
>> static int
>> show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, size_t span)
>> {
>> - unsigned long avg_bw_imc = 0, avg_bw_resc = 0;
>> + long avg_bw_imc = 0, avg_bw_resc = 0;
>> unsigned long sum_bw_imc = 0, sum_bw_resc = 0;
>> int runs, ret, avg_diff_per;
>> float avg_diff = 0;
>
> Same nit here about reverse fir order.
>
> Thank you very much for sticking with this to fix the warnings.
> With the nitpicks addressed you can add:
> | Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
Sure, I'll post another one with those two changes and your rb,
thanks for the review(s)!
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2024-05-08 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 19:41 [PATCH v3] selftests/resctrl: fix clang build warnings related to abs(), labs() calls John Hubbard
2024-05-08 20:24 ` Reinette Chatre
2024-05-08 20:32 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aeeb366-e28a-4b6c-a9c4-dd16882fd1a1@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).