* [PATCH] selftests/mm: import strings.h for ffsl
@ 2024-03-29 17:42 Edward Liaw
2024-03-29 19:33 ` Muhammad Usama Anjum
0 siblings, 1 reply; 4+ messages in thread
From: Edward Liaw @ 2024-03-29 17:42 UTC (permalink / raw
To: linux-kernel, Andrew Morton, Shuah Khan, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, Peter Xu,
David Hildenbrand, Mike Rapoport (IBM), Axel Rasmussen
Cc: linux-kselftest, kernel-team, Edward Liaw, linux-mm, llvm
Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix
map_hugetlb failure on 64K page size systems") imported vm_util.h.
Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
Signed-off-by: Edward Liaw <edliaw@google.com>
---
tools/testing/selftests/mm/vm_util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h
index c02990bbd56f..9007c420d52c 100644
--- a/tools/testing/selftests/mm/vm_util.h
+++ b/tools/testing/selftests/mm/vm_util.h
@@ -3,7 +3,7 @@
#include <stdbool.h>
#include <sys/mman.h>
#include <err.h>
-#include <string.h> /* ffsl() */
+#include <strings.h> /* ffsl() */
#include <unistd.h> /* _SC_PAGESIZE */
#define BIT_ULL(nr) (1ULL << (nr))
--
2.44.0.478.gd926399ef9-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/mm: import strings.h for ffsl
2024-03-29 17:42 [PATCH] selftests/mm: import strings.h for ffsl Edward Liaw
@ 2024-03-29 19:33 ` Muhammad Usama Anjum
2024-03-29 20:33 ` Edward Liaw
0 siblings, 1 reply; 4+ messages in thread
From: Muhammad Usama Anjum @ 2024-03-29 19:33 UTC (permalink / raw
To: Edward Liaw, linux-kernel, Andrew Morton, Shuah Khan,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Peter Xu, David Hildenbrand, Mike Rapoport (IBM), Axel Rasmussen
Cc: Muhammad Usama Anjum, linux-kselftest, kernel-team, linux-mm,
llvm
On 3/29/24 10:42 PM, Edward Liaw wrote:
> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix
> map_hugetlb failure on 64K page size systems") imported vm_util.h.
>
> Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
Why do you think this Fixes tag is needed? This refers to a patch which is
just moving code. It doesn't seem to have any thing related to strings.h.
Other than that, LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
> tools/testing/selftests/mm/vm_util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h
> index c02990bbd56f..9007c420d52c 100644
> --- a/tools/testing/selftests/mm/vm_util.h
> +++ b/tools/testing/selftests/mm/vm_util.h
> @@ -3,7 +3,7 @@
> #include <stdbool.h>
> #include <sys/mman.h>
> #include <err.h>
> -#include <string.h> /* ffsl() */
> +#include <strings.h> /* ffsl() */
> #include <unistd.h> /* _SC_PAGESIZE */
>
> #define BIT_ULL(nr) (1ULL << (nr))
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/mm: import strings.h for ffsl
2024-03-29 19:33 ` Muhammad Usama Anjum
@ 2024-03-29 20:33 ` Edward Liaw
2024-04-01 9:50 ` Muhammad Usama Anjum
0 siblings, 1 reply; 4+ messages in thread
From: Edward Liaw @ 2024-03-29 20:33 UTC (permalink / raw
To: Muhammad Usama Anjum
Cc: linux-kernel, Andrew Morton, Shuah Khan, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, Peter Xu,
David Hildenbrand, Mike Rapoport (IBM), Axel Rasmussen,
linux-kselftest, kernel-team, linux-mm, llvm
On Fri, Mar 29, 2024 at 12:32 PM Muhammad Usama Anjum
<usama.anjum@collabora.com> wrote:
>
> On 3/29/24 10:42 PM, Edward Liaw wrote:
> > Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix
> > map_hugetlb failure on 64K page size systems") imported vm_util.h.
> >
> > Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
> Why do you think this Fixes tag is needed? This refers to a patch which is
> just moving code. It doesn't seem to have any thing related to strings.h.
Oops, I guess it should be:
Fixes: 6f6a841fb77d ("selftest/vm: add helpers to detect PAGE_SIZE and
PAGE_SHIFT")
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/mm: import strings.h for ffsl
2024-03-29 20:33 ` Edward Liaw
@ 2024-04-01 9:50 ` Muhammad Usama Anjum
0 siblings, 0 replies; 4+ messages in thread
From: Muhammad Usama Anjum @ 2024-04-01 9:50 UTC (permalink / raw
To: Edward Liaw
Cc: Muhammad Usama Anjum, linux-kernel, Andrew Morton, Shuah Khan,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Peter Xu, David Hildenbrand, Mike Rapoport (IBM), Axel Rasmussen,
linux-kselftest, kernel-team, linux-mm, llvm
On 3/30/24 1:33 AM, Edward Liaw wrote:
> On Fri, Mar 29, 2024 at 12:32 PM Muhammad Usama Anjum
> <usama.anjum@collabora.com> wrote:
>>
>> On 3/29/24 10:42 PM, Edward Liaw wrote:
>>> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix
>>> map_hugetlb failure on 64K page size systems") imported vm_util.h.
>>>
>>> Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
>> Why do you think this Fixes tag is needed? This refers to a patch which is
>> just moving code. It doesn't seem to have any thing related to strings.h.
> Oops, I guess it should be:
>
> Fixes: 6f6a841fb77d ("selftest/vm: add helpers to detect PAGE_SIZE and
> PAGE_SHIFT")
LGTM
>
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-01 9:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-29 17:42 [PATCH] selftests/mm: import strings.h for ffsl Edward Liaw
2024-03-29 19:33 ` Muhammad Usama Anjum
2024-03-29 20:33 ` Edward Liaw
2024-04-01 9:50 ` Muhammad Usama Anjum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).