From: Nathan Chancellor <nathan@kernel.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] lib/test_bitops: Add benchmark test for fns()
Date: Tue, 7 May 2024 07:19:49 -0700 [thread overview]
Message-ID: <20240507141949.GA2746430@thelio-3990X> (raw)
In-Reply-To: <Zjld/ImGmyBHTLO4@yury-ThinkPad>
On Mon, May 06, 2024 at 03:47:24PM -0700, Yury Norov wrote:
> On Mon, May 06, 2024 at 08:08:41PM +0200, Miguel Ojeda wrote:
> > On Mon, May 6, 2024 at 7:52 PM Nathan Chancellor <nathan@kernel.org> wrote:
> > >
> > > No, unused can be used with local variables, used cannot.
> >
> > Yeah, sorry, I meant `used`, i.e. it is that one the one that
> > constraints the combination rather than `unused`.
> >
> > >From a quick look at the links in `compiler_attributes.h`, `unused`
> > can also be applied to types, while `used` cannot -- it is another
> > difference, but your sentence above already implies it anyway. :)
> >
> > Thanks for the correction!
>
> I have applied the patch in bitmap-for-next this weekend.
>
> https://github.com/norov/linux/commit/eb21fc0c96b48d1e779a0ab16f9165a3e0cd76ad
>
> Can you guys please take a look at it wrt the last comments? I think
> it's OK. But if not, I will resend it.
Yeah, I think it looks reasonable.
Cheers,
Nathan
next prev parent reply other threads:[~2024-05-07 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240502092443.6845-2-visitorckw@gmail.com>
2024-05-03 0:49 ` [PATCH v5 1/2] lib/test_bitops: Add benchmark test for fns() kernel test robot
2024-05-03 1:34 ` Kuan-Wei Chiu
2024-05-03 4:17 ` Nathan Chancellor
2024-05-03 7:31 ` Kuan-Wei Chiu
2024-05-03 7:38 ` Kuan-Wei Chiu
2024-05-03 15:54 ` Nathan Chancellor
2024-05-03 21:55 ` Yury Norov
2024-05-03 22:23 ` Nathan Chancellor
2024-05-05 10:42 ` Miguel Ojeda
2024-05-06 17:52 ` Nathan Chancellor
2024-05-06 18:08 ` Miguel Ojeda
2024-05-06 22:47 ` Yury Norov
2024-05-07 14:19 ` Nathan Chancellor [this message]
2024-05-05 10:42 ` Miguel Ojeda
2024-05-06 17:56 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507141949.GA2746430@thelio-3990X \
--to=nathan@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=visitorckw@gmail.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).