From: Jiri Kosina <jikos@kernel.org>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Blaž Hrastnik" <blaz@mxxn.io>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: surface-hid: Fix get-report request
Date: Tue, 15 Jun 2021 10:55:20 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2106151055080.18969@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210608132951.1392303-1-luzmaximilian@gmail.com>
On Tue, 8 Jun 2021, Maximilian Luz wrote:
> Getting a report (e.g. feature report) from a device requires us to send
> a request indicating which report we want to retrieve and then waiting
> for the corresponding response containing that report. We already
> provide the response structure to the request call, but the request
> isn't marked as a request that expects a response. Thus the request
> returns before we receive the response and the response buffer indicates
> a zero length response due to that.
>
> This essentially means that the get-report calls are broken and will
> always indicate that a report of length zero has been read.
>
> Fix this by appropriately marking the request.
>
> Fixes: b05ff1002a5c ("HID: Add support for Surface Aggregator Module HID transport")
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> ---
> drivers/hid/surface-hid/surface_hid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/surface-hid/surface_hid.c b/drivers/hid/surface-hid/surface_hid.c
> index 3477b31611ae..a3a70e4f3f6c 100644
> --- a/drivers/hid/surface-hid/surface_hid.c
> +++ b/drivers/hid/surface-hid/surface_hid.c
> @@ -143,7 +143,7 @@ static int ssam_hid_get_raw_report(struct surface_hid_device *shid, u8 rprt_id,
> rqst.target_id = shid->uid.target;
> rqst.instance_id = shid->uid.instance;
> rqst.command_id = SURFACE_HID_CID_GET_FEATURE_REPORT;
> - rqst.flags = 0;
> + rqst.flags = SSAM_REQUEST_HAS_RESPONSE;
> rqst.length = sizeof(rprt_id);
> rqst.payload = &rprt_id;
Queued in for-5.13/upstream-fixes branch, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-06-15 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 13:29 [PATCH] HID: surface-hid: Fix get-report request Maximilian Luz
2021-06-15 8:55 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2106151055080.18969@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=blaz@mxxn.io \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).