* [PATCH -next] tty: hvc: make hvc_rtas_dev static
@ 2022-10-19 6:44 ruanjinjie
2022-10-20 5:29 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: ruanjinjie @ 2022-10-19 6:44 UTC (permalink / raw
To: gregkh, jirislaby, linuxppc-dev, linux-kernel; +Cc: ruanjinjie
The symbol is not used outside of the file, so mark it static.
Fixes the following warning:
drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
not declared. Should it be static?
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
drivers/tty/hvc/hvc_rtas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
index e8b8c645482b..184d325abeed 100644
--- a/drivers/tty/hvc/hvc_rtas.c
+++ b/drivers/tty/hvc/hvc_rtas.c
@@ -26,7 +26,7 @@
#include "hvc_console.h"
#define hvc_rtas_cookie 0x67781e15
-struct hvc_struct *hvc_rtas_dev;
+static struct hvc_struct *hvc_rtas_dev;
static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] tty: hvc: make hvc_rtas_dev static
2022-10-19 6:44 [PATCH -next] tty: hvc: make hvc_rtas_dev static ruanjinjie
@ 2022-10-20 5:29 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2022-10-20 5:29 UTC (permalink / raw
To: ruanjinjie, gregkh, linuxppc-dev, linux-kernel
On 19. 10. 22, 8:44, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
> not declared. Should it be static?
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
> drivers/tty/hvc/hvc_rtas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
> index e8b8c645482b..184d325abeed 100644
> --- a/drivers/tty/hvc/hvc_rtas.c
> +++ b/drivers/tty/hvc/hvc_rtas.c
> @@ -26,7 +26,7 @@
> #include "hvc_console.h"
>
> #define hvc_rtas_cookie 0x67781e15
> -struct hvc_struct *hvc_rtas_dev;
> +static struct hvc_struct *hvc_rtas_dev;
>
> static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
> static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-19 6:44 [PATCH -next] tty: hvc: make hvc_rtas_dev static ruanjinjie
2022-10-20 5:29 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).