* Remove unused variable "cpu" from arch/x86/xen/setup.c
@ 2008-05-11 17:26 Manish Katiyar
2008-05-13 12:07 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Manish Katiyar @ 2008-05-11 17:26 UTC (permalink / raw
To: LKML
Remove unused variable "cpu" from arch/x86/xen/setup.c
Signed-off-by : Manish Katiyar (mkatiyar@gmail.com)
diff -Nur a/x86/xen/setup.c b/arch/x86/xen/setup.c
--- a/arch/x86/xen/setup.c 2008-04-26 20:36:15.000000000 +0530
+++ b/arch/x86/xen/setup.c 2008-05-11 22:50:35.000000000 +0530
@@ -71,7 +71,6 @@
void xen_enable_sysenter(void)
{
- int cpu = smp_processor_id();
extern void xen_sysenter_target(void);
/* Mask events on entry, even though they get enabled immediately */
static struct callback_register sysenter = {
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Remove unused variable "cpu" from arch/x86/xen/setup.c
2008-05-11 17:26 Remove unused variable "cpu" from arch/x86/xen/setup.c Manish Katiyar
@ 2008-05-13 12:07 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-05-13 12:07 UTC (permalink / raw
To: Manish Katiyar; +Cc: LKML, Thomas Gleixner, H. Peter Anvin
* Manish Katiyar <mkatiyar@gmail.com> wrote:
> Remove unused variable "cpu" from arch/x86/xen/setup.c
it's not unused:
> void xen_enable_sysenter(void)
> {
> - int cpu = smp_processor_id();
> extern void xen_sysenter_target(void);
> /* Mask events on entry, even though they get enabled immediately */
> static struct callback_register sysenter = {
if (!boot_cpu_has(X86_FEATURE_SEP) ||
HYPERVISOR_callback_op(CALLBACKOP_register, &sysenter) != 0) {
clear_cpu_cap(&cpu_data(cpu), X86_FEATURE_SEP);
^^^^^^^^^^^^^^
clear_cpu_cap(&boot_cpu_data, X86_FEATURE_SEP);
}
if it generates an unused variable warning on UP then per_cpu() needs to
be fixed to do a (void)(cpu) to indicate use of that variable.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-13 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 17:26 Remove unused variable "cpu" from arch/x86/xen/setup.c Manish Katiyar
2008-05-13 12:07 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).