* [PATCH] cgroup: Fix kernel-doc
@ 2021-05-26 2:49 Yang Li
2021-06-04 14:51 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-05-26 2:49 UTC (permalink / raw
To: tj; +Cc: lizefan.x, hannes, cgroups, linux-kernel, Yang Li
Fix function name in cgroup.c and rstat.c kernel-doc comment
to remove these warnings found by clang_w1.
kernel/cgroup/cgroup.c:2401: warning: expecting prototype for
cgroup_taskset_migrate(). Prototype was for cgroup_migrate_execute()
instead.
kernel/cgroup/rstat.c:233: warning: expecting prototype for
cgroup_rstat_flush_begin(). Prototype was for cgroup_rstat_flush_hold()
instead.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 'commit e595cd706982 ("cgroup: track migration context in cgroup_mgctx")'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
kernel/cgroup/cgroup.c | 2 +-
kernel/cgroup/rstat.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 21ecc6e..fc344f4 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2389,7 +2389,7 @@ struct task_struct *cgroup_taskset_next(struct cgroup_taskset *tset,
}
/**
- * cgroup_taskset_migrate - migrate a taskset
+ * cgroup_migrate_execute - migrate a taskset
* @mgctx: migration context
*
* Migrate tasks in @mgctx as setup by migration preparation functions.
diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c
index cee265c..7f0e589 100644
--- a/kernel/cgroup/rstat.c
+++ b/kernel/cgroup/rstat.c
@@ -220,7 +220,7 @@ void cgroup_rstat_flush_irqsafe(struct cgroup *cgrp)
}
/**
- * cgroup_rstat_flush_begin - flush stats in @cgrp's subtree and hold
+ * cgroup_rstat_flush_hold - flush stats in @cgrp's subtree and hold
* @cgrp: target cgroup
*
* Flush stats in @cgrp's subtree and prevent further flushes. Must be
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cgroup: Fix kernel-doc
2021-05-26 2:49 [PATCH] cgroup: Fix kernel-doc Yang Li
@ 2021-06-04 14:51 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2021-06-04 14:51 UTC (permalink / raw
To: Yang Li; +Cc: lizefan.x, hannes, cgroups, linux-kernel
On Wed, May 26, 2021 at 10:49:09AM +0800, Yang Li wrote:
> Fix function name in cgroup.c and rstat.c kernel-doc comment
> to remove these warnings found by clang_w1.
>
> kernel/cgroup/cgroup.c:2401: warning: expecting prototype for
> cgroup_taskset_migrate(). Prototype was for cgroup_migrate_execute()
> instead.
> kernel/cgroup/rstat.c:233: warning: expecting prototype for
> cgroup_rstat_flush_begin(). Prototype was for cgroup_rstat_flush_hold()
> instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 'commit e595cd706982 ("cgroup: track migration context in cgroup_mgctx")'
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Applied to cgroup/for-5.14.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-04 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-26 2:49 [PATCH] cgroup: Fix kernel-doc Yang Li
2021-06-04 14:51 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).