* [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt
@ 2022-10-18 10:47 Felix Riemann
2022-10-18 12:42 ` Andrew Lunn
2022-10-20 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Felix Riemann @ 2022-10-18 10:47 UTC (permalink / raw
To: Andrew Lunn, Heiner Kallweit, netdev; +Cc: linux-kernel, Felix Riemann
From: Felix Riemann <felix.riemann@sma.de>
If the cable is disconnected the PHY seems to toggle between MDI and
MDI-X modes. With the MDI crossover status interrupt active this causes
roughly 10 interrupts per second.
As the crossover status isn't checked by the driver, the interrupt can
be disabled to reduce the interrupt load.
Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
Signed-off-by: Felix Riemann <felix.riemann@sma.de>
---
drivers/net/phy/dp83822.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 8549e0e356c9..b60db8b6f477 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -254,8 +254,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
DP83822_EEE_ERROR_CHANGE_INT_EN);
if (!dp83822->fx_enabled)
- misr_status |= DP83822_MDI_XOVER_INT_EN |
- DP83822_ANEG_ERR_INT_EN |
+ misr_status |= DP83822_ANEG_ERR_INT_EN |
DP83822_WOL_PKT_INT_EN;
err = phy_write(phydev, MII_DP83822_MISR2, misr_status);
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt
2022-10-18 10:47 [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt Felix Riemann
@ 2022-10-18 12:42 ` Andrew Lunn
2022-10-20 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-10-18 12:42 UTC (permalink / raw
To: Felix Riemann; +Cc: Heiner Kallweit, netdev, linux-kernel
On Tue, Oct 18, 2022 at 12:47:54PM +0200, Felix Riemann wrote:
> From: Felix Riemann <felix.riemann@sma.de>
>
> If the cable is disconnected the PHY seems to toggle between MDI and
> MDI-X modes. With the MDI crossover status interrupt active this causes
> roughly 10 interrupts per second.
Make sense, it is trying to find the RX pair...
>
> As the crossover status isn't checked by the driver, the interrupt can
> be disabled to reduce the interrupt load.
>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> Signed-off-by: Felix Riemann <felix.riemann@sma.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt
2022-10-18 10:47 [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt Felix Riemann
2022-10-18 12:42 ` Andrew Lunn
@ 2022-10-20 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-20 3:10 UTC (permalink / raw
To: Felix Riemann; +Cc: andrew, hkallweit1, netdev, linux-kernel, felix.riemann
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 18 Oct 2022 12:47:54 +0200 you wrote:
> From: Felix Riemann <felix.riemann@sma.de>
>
> If the cable is disconnected the PHY seems to toggle between MDI and
> MDI-X modes. With the MDI crossover status interrupt active this causes
> roughly 10 interrupts per second.
>
> As the crossover status isn't checked by the driver, the interrupt can
> be disabled to reduce the interrupt load.
>
> [...]
Here is the summary with links:
- [net] net: phy: dp83822: disable MDI crossover status change interrupt
https://git.kernel.org/netdev/net/c/7f378c03aa49
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-20 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-18 10:47 [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt Felix Riemann
2022-10-18 12:42 ` Andrew Lunn
2022-10-20 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).