* drivers/base/fs/fs.h - needed?
@ 2002-12-17 20:04 Sam Ravnborg
2002-12-19 21:49 ` Patrick Mochel
0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2002-12-17 20:04 UTC (permalink / raw
To: mochel, linux-kernel
In fs/partitions/check.c the following ugly include exists:
#include <../drivers/base/fs/fs.h> /* Eeeeewwwww */
It can be killed with no problem, the prototypes contained therein are
not used by check.c.
Is this preparations for furter device model changes?
If thats the case, the fs.h file, or at least the content, shall be placed
in include/linux for general access.
Here is a patch to remove the said include statement.
Sam
===== fs/partitions/check.c 1.90 vs edited =====
--- 1.90/fs/partitions/check.c Thu Dec 5 20:01:25 2002
+++ edited/fs/partitions/check.c Tue Dec 17 20:57:02 2002
@@ -19,7 +19,6 @@
#include <linux/blk.h>
#include <linux/kmod.h>
#include <linux/ctype.h>
-#include <../drivers/base/fs/fs.h> /* Eeeeewwwww */
#include "check.h"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/base/fs/fs.h - needed?
2002-12-17 20:04 drivers/base/fs/fs.h - needed? Sam Ravnborg
@ 2002-12-19 21:49 ` Patrick Mochel
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Mochel @ 2002-12-19 21:49 UTC (permalink / raw
To: Sam Ravnborg; +Cc: linux-kernel
On Tue, 17 Dec 2002, Sam Ravnborg wrote:
> In fs/partitions/check.c the following ugly include exists:
> #include <../drivers/base/fs/fs.h> /* Eeeeewwwww */
>
> It can be killed with no problem, the prototypes contained therein are
> not used by check.c.
>
> Is this preparations for furter device model changes?
> If thats the case, the fs.h file, or at least the content, shall be placed
> in include/linux for general access.
It can safely be removed.
Thanks
-pat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-19 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-17 20:04 drivers/base/fs/fs.h - needed? Sam Ravnborg
2002-12-19 21:49 ` Patrick Mochel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).