From: Hariprasad Kelam <hkelam@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Naveen Mamindlapalli <naveenm@marvell.com>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH] octeontx2-pf: devlink params support to set TL1 round robin priority
Date: Tue, 14 May 2024 07:54:10 +0000 [thread overview]
Message-ID: <PH0PR18MB44744704A95A0BAD5AD05856DEE32@PH0PR18MB4474.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20240513161817.048123bf@kernel.org>
> On Mon, 13 May 2024 11:05:46 +0530 Hariprasad Kelam wrote:
> > Added support for setting or modifying transmit level (tl1) round
> > robin priority at runtime via devlink params.
> >
> > Octeontx2 and CN10K silicon's support five transmit levels (TL5 to TL1).
> > On each transmit level Hardware supports DWRR and strict priority,
> > depend on the configuration the hardware will choose the appropriate
> > method to select packets for the next level in the transmission process.
>
> Configuring DWRR parameters seems in no way HW specific.
> Please work on extending one of the Tx scheduling APIs to express this.
>
The driver offers per-interface DWRR params configuration with HTB offload.
Below are example commands having different classid with same priority value
tc class add dev ethx parent 1: classid 1:1 htb rate 10Gbit prio 1 quantum 2048
tc class add dev ethx parent 1: classid 1:2 htb rate 10Gbit prio 1 quantum 3048
Due to a hardware limitation, only a single DWRR group is supported on a transmit level.
To address this for physical functions (PFs) sharing a transmit level with their virtual functions (VFs),
a devlink option implemented to configure a priority value.
Thanks,
Hariprasad k
> pw-bot: cr
prev parent reply other threads:[~2024-05-14 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 5:35 [PATCH] octeontx2-pf: devlink params support to set TL1 round robin priority Hariprasad Kelam
2024-05-13 23:18 ` Jakub Kicinski
2024-05-14 7:54 ` Hariprasad Kelam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB44744704A95A0BAD5AD05856DEE32@PH0PR18MB4474.namprd18.prod.outlook.com \
--to=hkelam@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).